Comments (2)
billerickson
commented on July 30, 2024
Looks good to me. I've never seen that global $wp_styles used for conditionals, neat!
I'd use get_stylesheet_directory() instead of CHILD_URL. WP core recommends using functions rather than globals, and are deprecating them in core I think (couldn't find the ticket). I know these are Genesis global variables, but it's good practice to not use them.
It's a good idea to prefix the javascript and stylesheet slug (ea-global rather than global).
I'd leave the Javascript there, also creating a file in /inc/js/global.js. But I'd have the stylesheet part commented out.
from ea-genesis-child.
GaryJones
commented on July 30, 2024
I've never seen that global $wp_styles used for conditionals, neat!
http://code.garyjones.co.uk/enqueued-style-sheet-extras
I'd like to see the enqueueing of CSS and JS split into two different functions.
from ea-genesis-child.
Related Issues (20)
- Accessibility Error: Empty Button on Submenu dropdown HOT 3
- Create some basic comment styling
- 3rd party font rendering work around HOT 6
- Create GF basic error styling HOT 5
- Remove customizer stuff HOT 4
- Remove hover on hyperlinked icons HOT 1
- Genesis menu disappears sometimes HOT 1
- Smooth Scroll problem
- Add accessibility
- Flexbox Menus and more
- global.js updates for better validation HOT 6
- Genesis 2.3.0 adds image wrapper markup
- Remove the site title if a custom header is used? HOT 3
- CSS HOT 1
- Is this comment markup really correct? HOT 1
- ACF Custom Fields disappear from Admin menu HOT 2
- Undefined mixin media HOT 1
- Editor Style Not working HOT 1
- About menu
- Svg Icon HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ea-genesis-child.