GithubHelp home page GithubHelp logo

Comments (16)

bimlas avatar bimlas commented on May 23, 2024

The feature has been implemented, but it will still take some time to make it work on a smartphone. Please be patient!

What is missing is to navigate the content via keyboard short cuts

I have no plans to implement keyboard controls at this time because I would accidentally overwrite the default keymap of TiddlyWiki.

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

No problem. Button would be more than sufficient....Thanks a lot...

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

I don't see it in the latest version...Am i missing anything

image

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

Here's how I realize it (see the button bellow the standard search):

image

On smartphone it would become to an always available menu that would work the same as "find in page" in browsers.

Closed:

image

Opened:

image

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

I don't see it in the latest version...Am i missing anything

No, it's not released yet, but implemented (it works for, but you cannot use until I'm done).

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

Great...Super....Please update once it is done in the group as well....Is there a way to add goto option as well...Assume we have 1,000 matches....I want to go to 500th match...If possible and easy, implement that as well as part of this

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

Sorry, but I don't see the point. If you want to go to a more distant result, use your browser scroll, or if you are interested in this level of filtering, check out the TiddlyWiki filters.

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

No problem..That is optional...update once previous, next is implemented. if a glossy icon is possible with less kb..please consider....instead of gray...or customizable colour button...but what you are going to implement is awesome for sure..

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

Sorry, it takes some more time to do: basically I'm done, but it has compatibility issues and I don't like to release until everything works.

Javascript developers, please help: I tested the current version (demo is here, do not use it in real wikis, work in progress, etc.) on an old browser which is my phone's default (Samsung Browser 3.3 on Android), thus I think it may be an issue for others too.

Whenever I want to jump between results, it always jumps to the first or last result (just the opposite end of the search direction).

I am sure this is a problem with the code of the action-widget, or that the value of window.outerHeight (the height of the visible area) is incorrect in my browser (I also tried to query with window.innerHeight) or the value of this.previousMatch may not be stored.

Anyone familiar with Javascript (and specifically TiddlyWiki) programming could look at which instruction is incompatible with old browsers? You may have found a clear mistake in it that did not occur to me.

My other request would be to give it a try and play with it for a while to find out more errors.

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

I gave a try and it works awesome without any issues....One more thing i observed...It found matches in a page....How about having this option and have one more option previous, next in any page..which navigate to any level

  1. Find In Page - Previous, Next
  2. Find In Any Page - Previous, Next - Once it reaches the end of the page, it should automatically goes to the next page or next tiddler for the given text

Also, noticed one bug is that when we click the page, the text is getting highlighted but the first occurrence of the text should be on the top on the left hand side...else we need to scroll down to see even the first occurrence....

Also, other options if possible or quickly implemented,

  1. number of matches found in each page in brackets (2). currently all the matches is shown but not for each page..Attached the image for your kind reference

image

  1. Type-ahead assistance of the word while typing with matches found......

image

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

I will answer later, please check the latest release on https://bimlas.gitlab.io/tw5-highlight-searched-text

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

The latest release works well....If possible, consider the above suggestions and add it...That would be great...

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

Released, see https://bimlas.gitlab.io/tw5-highlight-searched-text

It show the number of highlighted matches on the page, I cannot count in not opened tiddlers.

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

Awesome...How about moving to next tiddler when the matches are fully navigated.

Example
Document1 - 10 matches
Documnet2 - 30 Matches
Document3 - 40 matches

after 10 matches are navigated with down arrow in document1, it should move on to Document2, instead it is keep on revolving in document1 only...

A minor bug which needs to be fixed.

from tw5-highlight-searched-text.

bimlas avatar bimlas commented on May 23, 2024

We may not understand each other.

If I understand you want the plugin to do a search on each tiddler ("file") and then use the next / previous button to open the next tiddler where it found the words you are looking for.

If this is the behaviour you really want, then you don't understand how the plugin works. It's not a search box (like standard search), it's just a text highlighter, it highlights the words you type in standard search in the currently displayed text, but does nothing with the currently not visible (closed) tiddlers. Jumping to the next / previous result is just an extra function, but it is also only jumping in visible text. As a result, I cannot implement the feature you want.

from tw5-highlight-searched-text.

prog20901 avatar prog20901 commented on May 23, 2024

Sure..No Issues...What ever is done is already perfect...Thank you so much for your efforts...

from tw5-highlight-searched-text.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.