Was BiscuitBuilder.build consuming itself intentional? about biscuit-rust

[jmhodges]

This might all come down to me not knowing what a Biscuit with only some of the symbols from the SymbolTable would mean?

[Geal]

right, so, the BiscuitBuilder holding a reference to the root key pair does not help much, it should instead receive the key pair as an argument to the build() method. This is something I intend to change for the next version.

The symbol table is used for string interning, and a part of the table can be known in advance (either the hardcoded default symbols, or a different symbol table can be provided during the build). So as Datalog elements are added to the builder, we add the new strings to the symbol table, and when building the token, we only keep the new strings to serialize them in the token, not the default ones.

So if you have a default symbol table holding "A", and "B", then add facts that use the strings "A", "C" and "D", you get a symbol table containing "A", "B", "C", and "D", but we split it to keep only the newer elements, "C", and "D".

But as with the root key pair, the builder should not hold the symbol table, instead it could be passed as argument to build()

[Geal]

FYI the builder API changed in #86, it does not hold a reference to the root key anymore