GithubHelp home page GithubHelp logo

Comments (5)

jonatack avatar jonatack commented on June 3, 2024

Hmm. Is there a PR you have in mind that changed a lot afterward? I imagine we would want to still link to the live PR in bitcoin/bitcoin to encourage reviewing it. If we don't fork, for the obsolescence reasons you mention CONTRIBUTING.md could suggest to avoid using commit links/refs in the notes and questions, and when feasible to use the most recent release branch for links to the codebase (for instance, in yesterday's notes when describing the current behaviour the links were to 0.19).

from website.

jonatack avatar jonatack commented on June 3, 2024

My intuition is that the living aspect of the actual repo is more compelling than a museum fork ;) nevertheless you raise good points worth considering.

from website.

jnewbery avatar jnewbery commented on June 3, 2024

One example: the meeting log here: https://bitcoincore.reviews/15996.html contains a link to bitcoin/bitcoin@0c39465 - a commit which no longer exists.

from website.

jonatack avatar jonatack commented on June 3, 2024

Right, that link in the log should be updated. I agree that it would be good to use a fork for links. Would require an addition to the contributing notes.

from website.

jnewbery avatar jnewbery commented on June 3, 2024

Done in #108

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.