Comments (8)
BIP21 formatted QR codes require an address. Even if I extend it with BIP72, I will continue requiring an address (and an amount, if present in the payment request) in order to link the URL to the payment request. For backwards compatibility I expect services to use these fields anyway.
from bitcoin-wallet.
That's not compliant with the spec, which says
If the "r" parameter is provided and backwards compatibility is not required, then the bitcoin address portion of the URI may be omitted (the URI will be of the form: bitcoin:?r=... ).
That means it's up to the creator of the URI if backwards compatibility is required or not, not the wallet author.
I don't understand what you mean by "link the URL to the payment request"? If a payment request is present the data in the URI is ignored. At any rate, crashing with a NPE is definitely the wrong thing to do.
from bitcoin-wallet.
We talked about the linking several times. The goal is I can be sure the payment request is from the person who showed me the QR code. Since up to now no better solution was agreed on, I will use what I have.
The spec is "draft" for a reason.
from bitcoin-wallet.
Why would someone show you a QR code with someone else's payment request on it?
from bitcoin-wallet.
The "request for the payment request" can be MITM'ed. X.509 is of no value for face to face payments.
from bitcoin-wallet.
Sure, I'm not saying generate addressless qr codes yourself. Just don't
crash when reading them :)
On 7 Feb 2014 18:48, "Andreas Schildbach" [email protected] wrote:
The "request for the payment request" can be MITM'ed. X.509 is of no value
for face to face payments.—
Reply to this email directly or view it on GitHubhttps://github.com/schildbach/bitcoin-wallet/issues/44#issuecomment-34480251
.
from bitcoin-wallet.
Sure, I'm with you on that. I will fix this crash shortly.
from bitcoin-wallet.
Fixed.
from bitcoin-wallet.
Related Issues (20)
- where can I find the txid
- Can`t build Gradle task svgToPngMipmap "Value is null"
- Incorrect fees HOT 3
- Sent using economic fee, transaction does not confirm HOT 5
- Smartphone died, restore failed HOT 2
- Low transaction fee causing Invalid BTC Transaction HOT 4
- Problem with my paiement HOT 4
- Request | Change Fee System HOT 14
- Attempting restore of wallet results in empty wallet HOT 3
- Unable to send Bitcoin HOT 2
- Btc
- Raising the fee from economic to normal would be doable, but does it really make sense? I think almost all users of this action have lost patience and want their txn to confirm asap (aka "priority"), regardless of the original intent. HOT 1
- Help: Bitcoin-Wallet Version 4.56, last updated 2016 HOT 1
- F-Droid app description i18n
- IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change.
- Invalid BTC Transaction
- Does bitcoin testnet wallet support redirections? HOT 1
- Forgive me, but is this software swallowing my bitcoins? HOT 1
- Issue with the correct path for the Segwit. HOT 2
- Incorrect transifex link on https://wallet.schildbach.de/ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin-wallet.