Comments (6)
schildbach
commented on May 2, 2024
If you look at InputParser.parseAndHandlePaymentRequest() it gets the pkiVerificationData from the PaymentSession, but verificationData.rootAuthority.getCAName() does not return any name in the case of Gavins requests. Even if you .toString() the certificates themselves you do not see a well-known CA name. So I guess he just faked his own or something. I wanted to ask him but did not see him around lately.
from bitcoin-wallet.
mikehearn
commented on May 2, 2024
Ah, that's the bug. Check the pkiData.orgName field instead. Checking the CA name of the root authority will not work because usually, a root authority is not signed by another CA.
from bitcoin-wallet.
schildbach
commented on May 2, 2024
So you mean verificationData.rootAuthority.orgName?
from bitcoin-wallet.
mikehearn
commented on May 2, 2024
Oh, that's annoying. Somehow I missed during code review that PaymentSession isn't making this data easily available. Will fix now.
from bitcoin-wallet.
mikehearn
commented on May 2, 2024
OK, I uploaded a commit that shows how to fix it. For now could you copy/paste the getNameFromCert method into your code? Once we do a 0.11.1 we can include that commit and then you can update to it.
from bitcoin-wallet.
schildbach
commented on May 2, 2024
Fixed.
from bitcoin-wallet.
Related Issues (20)
- where can I find the txid
- Can`t build Gradle task svgToPngMipmap "Value is null"
- Incorrect fees HOT 3
- Sent using economic fee, transaction does not confirm HOT 5
- Smartphone died, restore failed HOT 2
- Low transaction fee causing Invalid BTC Transaction HOT 4
- Problem with my paiement HOT 4
- Request | Change Fee System HOT 14
- Attempting restore of wallet results in empty wallet HOT 3
- Unable to send Bitcoin HOT 2
- Btc
- Raising the fee from economic to normal would be doable, but does it really make sense? I think almost all users of this action have lost patience and want their txn to confirm asap (aka "priority"), regardless of the original intent. HOT 1
- Help: Bitcoin-Wallet Version 4.56, last updated 2016 HOT 1
- I have forgotten my SPENDING PIN HOT 1
- IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change.
- Invalid BTC Transaction
- Does bitcoin testnet wallet support redirections? HOT 1
- Forgive me, but is this software swallowing my bitcoins? HOT 1
- Issue with the correct path for the Segwit. HOT 2
- Incorrect transifex link on https://wallet.schildbach.de/ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin-wallet.