Comments (6)
sandakersmann
commented on June 15, 2024
Already done in 76e123a#diff-4a59b408ad3778278c3aeffa7da33c3cL128
from bitcoinclassic.
hikari-no-yume
commented on June 15, 2024
Ah, alright then! Should the constant be removed, then?
from bitcoinclassic.
zander
commented on June 15, 2024
It could, and technically it should.
But to avoid merge conflicts, I'd leave it.
Leave this PR open for a while, since we now had 2 PRs for this same line in 2 days.
from bitcoinclassic.
hikari-no-yume
commented on June 15, 2024
Yeah, I was thinking merge conflicts might be an issue. Maybe a comment could be added above that line to point out that it's no longer used in Classic?
from bitcoinclassic.
zander
commented on June 15, 2024
Yeah, I was thinking merge conflicts might be an issue. Maybe a comment could be added above that line to point out that it's no longer used in Classic?
That would still cause a merge conflict :)
from bitcoinclassic.
hikari-no-yume
commented on June 15, 2024
True!
from bitcoinclassic.
Related Issues (20)
- Replace C-includes with C++ includes HOT 2
- BCH Wallet balance shows BTC Wallet balance HOT 3
- BCH Wallet balance shows BTC Wallet balance HOT 1
- Flexible Transactions protocol enhancement ideas
- Can not run bitcoind or bitcoin-qt due to bad config, unknown what config it is using HOT 4
- right click on multiple highlighted transactions HOT 1
- UAHF 1.3.5 Misbehaving: A.B.C.D:8333, id:193 (0 -> 100) BAN THRESHOLD EXCEEDED HOT 10
- 1.3.5uahf Mac OS, 'No block source available' after migration HOT 6
- Bitcoin Classic cannot use an existing Cash blockchain HOT 4
- Shares Mac bundle-id with Core Bitcoin-Qt app HOT 1
- Failed to revert a block during new install of V1.3.6 HOT 6
- Q: Addr message returning up to 2500 addresses not a bit too much? HOT 3
- The EDA is a serious issue HOT 1
- UAHF not downloading blocks HOT 13
- Mac app doesn't quit when reindexing blocks HOT 2
- [build error] bitcoinconsensus.cpp:88:114 - error: no matching constructor for initialization of 'TransactionSignatureChecker' HOT 3
- [proposed refactor] s/NULL/nullptr/g
- [proposed refactor] BOOST_FOREACH -> C++11 Range-based for loop
- Nov 13 HF marking needed? HOT 3
- xss reflected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoinclassic.