Comments (4)
Hi @maderlock ,
thanks for the feedback, much appreciate it!
I think the best way would be to canonicalize, because I think at the end "/foo/bar" and "/foo/bar/" representing the same endpoint. Is there any reason why you think this could be fragile?
I think doubling every rule would be an overhead mess, and regex should be for more complex stuff.
from magento2-force-login.
No, I don't think that would be fragile. I cannot think of a useful case where you would want a bareword to differ from that same bareword plus a slash - nobody would find that intuitive I think
from magento2-force-login.
Fixed this issue with RC3 of v2.1.0
from magento2-force-login.
That's great, thanks. I'll pull this into the site I'm working on and see how it fares in user testing.
from magento2-force-login.
Related Issues (20)
- Module not enabled but redirect to homepage HOT 4
- [improve] Add field on CMS pages to authorize them to not force login HOT 2
- Homepage Redirect After Login Leads To incorrect url HOT 15
- table or view not found HOT 4
- Paypal Ipn HOT 5
- Not compatible with Magento 2.4.0 Commerce HOT 8
- incompatible with community Edition 2.4.0 HOT 1
- Call to undefined method setUrl on Forward class HOT 5
- white list missing Admin Uri HOT 4
- Secondary view problem redirect HOT 2
- Cannot get past /customer/account/loginPost/ when Redirect Customer to Account Dashboard after Logging in is set to "Yes" HOT 1
- 404 present in #180 still present in 4.1.0 HOT 2
- Login as Customer from admin panel HOT 2
- Error while composer require 5.0 HOT 4
- Password Reset Endless redirect HOT 4
- Problem with upgrade: 1061 Duplicate key name 'BITEXPERT_FORCELOGIN_WHITELIST_URL_RULE_STORE_ID' HOT 9
- Circular dependency: Magento\Customer\Model\Plugin\CustomerNotification depends on Magento\Customer\Model\Plugin\CustomerNotification and vice versa. HOT 2
- Exception #0 (Exception): Deprecated Functionality: strpos(): Non-string needles will be interpreted as strings in the future HOT 1
- Restore default whitelist all get static strategy HOT 9
- PHP 8.2 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2-force-login.