Supporting `npm ci` in CI configs about typescript-starter

[bitjson]

Sounds great – is there any downside to just replacing usages of npm install with npm ci in all the CI config? I don’t think think we need a conditional check.

I’d love to take a PR!

[cspotcode]

I added the conditional check for when running an older version of `npm`, since that command was added in the latest release.

…

On Sat, Mar 17, 2018, 1:07 PM Jason Dreyzehner ***@***.***> wrote: Sounds great – is there any downside to just replacing usages of npm install with npm ci in all the CI config? I don’t think think we need a conditional check. I’d love to take a PR! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAW-uNhxRC52mjg5EC9OU_V18QvOCErgks5tfUK5gaJpZM4SuGVG> .

[bitjson]

Ah, you're right about npm ci being a little more complicated right now. I added caching to each of the configurations for now (07f7a36).

I'm hesitant to immediately switch to npm ci since we'd have to update npm on each CI environment before using npm ci. (Each is at 5.6.0 right now.)

It adds enough to the configuration complexity and build time that I think we're better off just waiting until npm 5.7.0 is available by default on each service before switching over. Leaving open for now.

---

If you're reading this issue in the future – and CircleCI, Travis CI, and/or Appveyor now ship with at least [email protected] by default – please send a PR!

[cspotcode]

FWIW that conditional one-liner detects if npm supports the `ci` command so you don't need to update npm; it'll fallback to `install`. Also, an npm install fallback will always be necessary. Some projects run their node tests on multiple versions of node (down to 0.10) so they'll be running old versions of npm, too. But I'm fine holding off, too.

…

On Tue, Mar 20, 2018, 10:29 PM Jason Dreyzehner ***@***.***> wrote: Ah, you're right about npm ci being a little more complicated right now. I added caching to each of the configurations for now (07f7a36 <07f7a36> ). I'm hesitant to immediately switch to npm ci since we'd have to update npm on each CI environment before using npm ci. (Each is at 5.6.0 right now.) It adds enough to the configuration complexity and build time that I think we're better off just waiting until npm 5.7.0 is available by default on each service before switching over. Leaving open for now. ------------------------------ If you're reading this issue in the future – and CircleCI, Travis CI, and/or Appveyor now ship with at least ***@***.*** by default – please send a PR! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAW-uGNG8v24LI_UJcep6x51dyeL0TSvks5tgbsNgaJpZM4SuGVG> .

[bitjson]

Also, an npm install fallback will always be necessary.

Good point. So once there's a CI environment which supports 5.7.0, we'll still want to use the conditional. 👍

[bitjson]

Now that this is the default on any reasonably modern version of npm or yarn, I think it's safe for us to mark this as "done". 😅

Thanks again for opening the issue!