GithubHelp home page GithubHelp logo

Comments (8)

matthewp avatar matthewp commented on August 23, 2024

I don't understand, what does prepublish have to do with install?

from syn.

mickmcgrath13 avatar mickmcgrath13 commented on August 23, 2024

idk. I run npm install, and a build runs if "prepublish" is there. Does scripts run on npm install?

from syn.

mickmcgrath13 avatar mickmcgrath13 commented on August 23, 2024

https://docs.npmjs.com/misc/scripts

prepublish: Run BEFORE the package is published. (Also run on local npm install without any arguments.)

from syn.

matthewp avatar matthewp commented on August 23, 2024

Oh, I think it's fine that it does the build. It's something we do in several projects. The reason we created that is to make sure the build happens before publish.

from syn.

mickmcgrath13 avatar mickmcgrath13 commented on August 23, 2024

lol @ npm/npm#3059

..apparently "prepublish" running on npm install is kind of a big deal, and that's just the way it works.

Also, npm install --ignore-scripts does the install the way I would expect, but I would think the general case for people should be clone, and npm install... I wouldn't expect people to remember the --ignore-scripts part, and without it, they'll get local file changes.

from syn.

matthewp avatar matthewp commented on August 23, 2024

Yeah, we should gitignore the dist/ folder in master and only publish it in a tag by force adding.

from syn.

mickmcgrath13 avatar mickmcgrath13 commented on August 23, 2024

#103

from syn.

mickmcgrath13 avatar mickmcgrath13 commented on August 23, 2024

closing in lieu of #106

from syn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.