Centos 6.3 Build Error: "conflicting types for ‘UTP_Write’" about libutp

[cfpp2p]

cfpp2p@39d0263

[ghazel]

bool is defined (conditionally) in utypes.h not utp.h. So that's one thing to address first.

Next, what is __bool_true_false_are_defined? Finally, utp.cpp itself is C++ obviously, so there's no pressing need to define true and false in the header.

[jordanl]

__bool_true_false_are_defined is a macro from stdbool.h to detect whether those keywords have already been defined.

The issue is that the compiler isn't smart enough to understand that the different typedefs from utypes.h, stdbool.h, and elsewhere are really the same unsigned char, so compilation fails with a mismatch.

Including stdbool.h in the not-C++ block of utypes.h would fix this. I don't know how universal stdbool.h is on your target platforms, but you could possibly drop the HAVE_STDBOOL_H autoconf idiom.

[ghazel]

Certainly there is no stdbool.h on Windows. Also we don't have autoconf to set HAVE_STDBOOL_H.

Any easy answer here would be just use ints. That seems unlikely to bite me again (#12).

Why does the state of C89/C99/C++ have to be so terrible?

[jordanl]

Blah, I forgot about #12.

int sounds like it might be the least-bad choice.