`Date.to_secs` does not take timezone into account. about timex

[bitwalker]

For anyone that may want to help tackle this, if you find yourself making any code changes to the Timezone.* modules, ping me first.

[bbense]

Looking at the code this probably is also a bug in to_days, although you'd need to look a lot harder to find a specific example.

[bbense]

I made a first pass at this problem by writing a test that fails and a simple solution, however it seems to be causing problems in other code. Date.to_secs is fundamental to many other functions and I may be running into chicken and egg issues.

The code is here if you want to look, will keep plugging away as I have time.

https://github.com/bbense/timex/tree/Date_to_secs_bug_24

[bbense]

This patch resolves the bug.

#32

No changes to the Timezone code were required, but other methods in Date required some reworking to adapt to the changes in to_secs.

[bitwalker]

Merged and published as part of the 0.13.3 release. Thanks! Do you happen to know which functions specifically required rework? I can dig through and find out, but if you know offhand, then I can open a new issue to track that.

[bbense]

Date.shift and Date.compare

On Fri, Jan 9, 2015 at 4:28 PM, Paul Schoenfelder [email protected]
wrote:

Merged and published as part of the 0.13.3 release. Thanks! Do you happen
to know which functions specifically required rework? I can dig through and
find out, but if you know offhand, then I can open a new issue to track
that.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[bbense]

Oh and Date.diff

On Fri, Jan 9, 2015 at 4:37 PM, Booker Bense [email protected] wrote:

Date.shift and Date.compare

On Fri, Jan 9, 2015 at 4:28 PM, Paul Schoenfelder <
[email protected]> wrote:

Merged and published as part of the 0.13.3 release. Thanks! Do you happen
to know which functions specifically required rework? I can dig through and
find out, but if you know offhand, then I can open a new issue to track
that.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[bitwalker]

@bbense Excellent, thank you sir! Might be a good place to start if you are looking for another issue to tackle. I'll cc you on it when I create it, you can decide whether you want to work that one or not.