Passwords with spaces fail login and unlock about cli

[kspearrin]

Try using double quotes?

bw unlock "password with spaces"

[w1ngnutt]

I've tried both with single quotes and with double quotes. I originally noticed the issue when I couldn't get the bitwarden-rofi project to work: https://github.com/mattydebie/bitwarden-rofi

[kspearrin]

I just tested both of the following:

bw unlock "password with spaces"
bw unlock 'password with spaces'

and they seemed to work without issue. Windows 10.

[w1ngnutt]

I only have linux systems available to test with. I'll see if I can get access to a windows pc for testing and report back.

…

On Wed, Dec 5, 2018 at 9:15 PM Kyle Spearrin ***@***.***> wrote: I just tested both of the following: bw unlock "password with spaces" bw unlock 'password with spaces' and they seemed to work without issue. Windows 10. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFeJQsoZMYD5GF6IfPFVgAG0ruxs13Tks5u2H3QgaJpZM4ZAu9x> .

-- Justin Milam [email protected] [phone]

[kspearrin]

Note that this was using gitbash window on Windows 10, which should behave the same as a Linux bash terminal.

[Mange]

I can confirm the same issue. I can copy my master password and it is accepted when I enter it in the interactive prompt, but doing bw unlock "<paste>" will not accept it (I've of course also tried entering it manually).

› bw --version
1.6.0
› uname -a
Linux morbidus 4.19.12-arch1-1-ARCH #1 SMP PREEMPT Fri Dec 21 13:56:54 UTC 2018 x86_64 GNU/Linux
› $SHELL --version
zsh 5.6.2 (x86_64-pc-linux-gnu)

[Mange]

I changed the source code for my command to always prompt for the master password and to print out a debug representation of the input password. This shows the problem nicely:

› bw unlock "this is a test"
'this'
? Master password: [hidden]
'this is a test'
Invalid master password.

Code change:

		var util = require("util"); //NEW
		console.log(util.inspect(password)); // NEW
            //if (password == null || password === '') {
            if (true) { // NEW
                const answer = yield inquirer["createPromptModule"]({ output: process.stderr })({
                    type: 'password',
                    name: 'password',
                    message: 'Master password:',
                });
                password = answer.password;
		console.log(util.inspect(password)); // NEW

[Mange]

I found the bug: It's in the shell wrapper script (/usr/bin/bw in my case).

#!/bin/sh
node /usr/lib/bitwarden-cli/bw.js $@

Note that the arguments are passed on with whitespace splitting enabled. Making it quote the arguments made everything work for me.

#!/bin/sh
node /usr/lib/bitwarden-cli/bw.js "$@"

[w1ngnutt]

The above change fixes the issue for me as well.

[w1ngnutt]

This appears to be an issue with the shell script included by the package maintainer, not this project. I'll report there.

https://aur.archlinux.org/packages/bitwarden-cli/