GithubHelp home page GithubHelp logo

add a PiP mode to the Android app about multivnc HOT 4 OPEN

bk138 avatar bk138 commented on May 22, 2024
add a PiP mode to the Android app

from multivnc.

Comments (4)

gujjwal00 avatar gujjwal00 commented on May 22, 2024

I am planning to work on this. Here is the behavior I am thinking about:

  • Enabled by default on supported devices
  • On onUserLeaveHint, if connected, enter PiP mode
  • Set PiP window's aspect ratio to match with framebuffer
  • After entering
    • Set zoom level to fill the entire VncCanvas
    • Hide controls
  • After exiting
    • Set zoom to 100% or remember the old zoom?
    • Show controls
  • Auto-close PiP if disconnected?
  • If we enter PiP mode and user starts a new connection by going back to app
    • We can start a new VncCanvasActivity, leaving the PiP activity as is, or
    • We declare VncCanvasActivity as singleTask. We will then receive onNewIntent call where we can start a new fullscreen VncCanvasActivity and close the one in PiP mode.

from multivnc.

bk138 avatar bk138 commented on May 22, 2024

Super nice @gujjwal00! You probably already know https://github.com/bk138/multivnc/tree/feat-android-pip where some work has started already. Beforehand, it's probably good to reason about the actual benefits of this. I started working on this as some sort of "fancy" feature but then realised it's of not much use at least for me. Maybe some kinda sysadmin use case? I'm pretty sure that if that feature comes, it should be configurable.

from multivnc.

gujjwal00 avatar gujjwal00 commented on May 22, 2024

Yes I was planning to pickup from https://github.com/bk138/multivnc/tree/feat-android-pip .

I personally don't have much use either (just once in a while).

So probably defer it until concrete use cases arise?

from multivnc.

bk138 avatar bk138 commented on May 22, 2024

Yes I was planning to pickup from https://github.com/bk138/multivnc/tree/feat-android-pip .

I personally don't have much use either (just once in a while).

So probably defer it until concrete use cases arise?

OK with me, it's rather a nice-to-have. Maybe someone chimes in here and expresses dire need, than it can be elevated :-)

from multivnc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.