GithubHelp home page GithubHelp logo

Comments (2)

cloudwu avatar cloudwu commented on July 17, 2024

https://github.com/bkaradzic/bx/blob/master/include/bx/inline/math.inl#L665

I think use rsqrt would be better

  const float invLen = rsqrt(dot(_a, _a));

Because sqrt is implemented with rsqrt https://github.com/bkaradzic/bx/blob/master/include/bx/inline/simd_ni.inl#L200-L211

On this issue, I suggest to clamp (_dir.y ,-1, 1) in toLatLong

inline void toLatLong(float* _outU, float* _outV, const Vec3 _dir)
{
	const float phi   = atan2(_dir.x, _dir.z);
	const float theta = acos(clamp(_dir.y, -1, 1));

	*_outU = (kPi + phi)/kPi2;
	*_outV = theta*kInvPi;
}

from bx.

bkaradzic avatar bkaradzic commented on July 17, 2024

Grab latest...

from bx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.