GithubHelp home page GithubHelp logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 28, 2024
Even if it was a good idea, on the technical side there is no good solution for 
cases like:

<jsp:include name="html" value="<br/>" /> 

as "/>" is not unique enough sequence to assume it won't be used anywhere 
inside jsp tag. I am currently just using regular expressions for parsing, this 
would require full scale jsp grammar parser to get it right.

If you need extra features you can always just download the sources and modify 
them to your needs. 

Original comment by [email protected] on 27 Aug 2010 at 5:58

  • Changed state: WontFix
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

from htmlcompressor.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 28, 2024
You are right, however the same is also happening here:

<script type="text/javascript">
<!--
// Don't forget to add </script> at the end!
document.write('bla bla bla');
[...]
-->
</script>

The regexp you're using would not realize the first </script> should be ignored.

Isn't this the same case?

Original comment by [email protected] on 27 Aug 2010 at 6:17

from htmlcompressor.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 28, 2024
You are not allowed to have </script> tag anywhere inside, it should be always 
masked: <\/script>.

Maybe I can add support for custom skip rules, so you can manually add any 
regexp you like. I will try to look into it on the weekend and see how it fits 
into the picture, can't promise anything though.

Original comment by [email protected] on 27 Aug 2010 at 3:20

from htmlcompressor.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 28, 2024
Well, that would certainly be very interesting!

Original comment by [email protected] on 27 Aug 2010 at 7:25

from htmlcompressor.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 28, 2024
Custom rules were added in 0.9.2 (see the front page for examples). Hopefully 
this solves it.

Original comment by [email protected] on 28 Aug 2010 at 2:25

  • Changed state: Fixed

from htmlcompressor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.