GithubHelp home page GithubHelp logo

Comments (3)

sneves avatar sneves commented on June 3, 2024

Clang sees the aligned(64) hint in blake2.h and thinks "hey, I can emit aligned loads for every structure of this kind". This usually works, because the compiler will also have control of the allocation of the structures.

However, in the blake2*p case we define an array of structures whose sizeof is not a multiple of 64. This forces the 2nd, 3rd, etc structures to be misaligned and is what causes the crash. The solution is simple: remove the alignment hint from blake2.h. This is as simple as commenting __attribute__ ((__aligned__(x))) in line 23. I used to rely on the alignment of structures in early versions of the code, but that is no longer the case, so doing this is perfectly safe.

from blake2.

ivan avatar ivan commented on June 3, 2024

Thanks! That does fix the crash. (Tested clang-3.6)

from blake2.

sneves avatar sneves commented on June 3, 2024

Also fixed in this repo now.

from blake2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.