Comments (3)
Clang sees the aligned(64)
hint in blake2.h
and thinks "hey, I can emit aligned loads for every structure of this kind". This usually works, because the compiler will also have control of the allocation of the structures.
However, in the blake2*p case we define an array of structures whose sizeof
is not a multiple of 64. This forces the 2nd, 3rd, etc structures to be misaligned and is what causes the crash. The solution is simple: remove the alignment hint from blake2.h
. This is as simple as commenting __attribute__ ((__aligned__(x)))
in line 23. I used to rely on the alignment of structures in early versions of the code, but that is no longer the case, so doing this is perfectly safe.
from blake2.
Thanks! That does fix the crash. (Tested clang-3.6)
from blake2.
Also fixed in this repo now.
from blake2.
Related Issues (20)
- Perfromance degradation on ARM Cortex-M3 with NATIVE_LITTLE_ENDIAN defined HOT 3
- OID for blake2s? HOT 1
- Update binaries at blake2.net
- Porting on SPARC CPU HOT 3
- 'b2sum' names conflict HOT 1
- Tree test vectors missing
- different read blocksize result in failed checksum HOT 8
- Keyed hash test case for an independent implementation HOT 3
- Diagonal shuffle optimization for BLAKE2s
- blake2 HOT 1
- Any plan to make a new release? HOT 4
- Autotools configure.ac and Makefile.am
- Support for Apple Silicon on macOS (mach-o ARM64) HOT 2
- Status of blake2.net implementation list
- Provide a reference implementation for BLAKE2sp and BLAKE2bp in Java
- npm-gyp failer to rebuild blake2 HOT 1
- Include Blake2x HOT 1
- Question: What is the maximum key lenght that BLAKE2x can proccess?
- Questions about Blake2x: Its state size (internal state) and its security when generating keys with size more than 256/512bits HOT 1
- Question: Where do IV values come from? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blake2.