Differences with js-stringify? about javascript-stringify

[blakeembrey]

The code of js stringify is 10 lines and I referenced it already, I’d check that out if you want to know more about it since I didn’t write it. Once again, based on the code review I did for you, that library is mainly JSON stringify with support for dates while this library is designed to stringify any JavaScript for execution later (e.g. generate code from runtime objects).

[blakeembrey]

Please take some time to do reviews for yourself instead of putting the burden on an OSS maintainer to run comparisons for you. That said, if you look at https://github.com/pugjs/js-stringify/blob/master/index.js all it is is a slightly modified JSON stringify. Compared to the goal of this module which is to stringify the entire JavaScript object representation so it can be evaluated at a later date.

[stevenvachon]

Can the result of js-stringify not be evaluated at a later date? The purpose of a readme is to describe why the package is useful, not just how it's used.

[blakeembrey]

What didn’t you understand from the README? If you don’t feel it’s good enough, submit a PR. I looked at the code for the library you asked me to compare because it’s README had no examples of what it did so I couldn’t compare it.

[stevenvachon]

that library is mainly JSON stringify with support for dates

JSON.stringify with support for Date, undefined and a bunch of Unicode characters that I'm not familiar with.

You could choose to improve your readme by explaining more about how it differs from JSON.stringify

[blakeembrey]

Feel free to submit a PR. I would have expected looking at the examples in the README would have provided you all the differences to JSON stringify but I’ll keep it in mind.