Use of Pointers about semver

[blang]

Yep you're absolutely, a old (bad) habit of me, which never got fixed.
I will work on that the next days,

thx for pointing that out

[xogeny]

This is still a little inconsistent because in many cases the arguments are still pointers even though (again, they are not mutated).

[blang]

Yep, you were faster than me.
I will check if those are api breaking

[xogeny]

You might also want to double-check any benchmarks you do to make sure there isn't a performance impact. Just a thought.

[blang]

I'm not quite sure if changing from pointers to value arguments helps anyone.
For example:

func (v Version) Compare(o Version) int

Would no longer work if the o Version is constructed using New(..) or Parse(..)
Which could be avoided by returning values instead of pointers, since we don't often modify the version, but then we could not return nil,err in case of failure.

Any ideas?

[xogeny]

In my opinion, Parse should return a value, not a pointer and the API should generally use values. This is essentially just struct with a few values. I normally only use pointers when I want to have a receiver that gets mutated.

As for the "we could not return nil, err" comment, that isn't really an issue. If you return a value (not a pointer), just return Version{}, err. Does that answer your question?

[blang]

Yep i know, but i'm (still) not fully convinced of the benefits because this will break the public api.

Anyway, i've changed to values-only in the v2 branch, have a look at c8864c2
I think this looks good and benchmarks are ok.
Also have a look at the v2 branch adding sorting of version slices.
feat_v2

I will probably merge this in a couple of days.

[blang]

Implemented in v2