Windows Container support about goldpinger

[rbtr]

@jkroepke that's @tyler-lloyd who was investigating implementing this. those are very unofficial dev/test images but are probably functional

[seeker89]

It's a good point. I have no experience with Windows Containers, but I'd be happy to assist anyone who'd like to give it a shot.

[rbtr]

@seeker89 I'm willing to pick this feature up (because I would like to use it, ofc), but I will warn you up front that making multiplat images for Windows is a bit ugly 🙂

[seeker89]

That would be awesome!

[jkroepke]

I found some windows images on DockerHub (careful: random user), no github project linked: https://hub.docker.com/r/tylloyd/goldpinger

[tyler-lloyd]

@jkroepke, @rbtr is right. very unofficial. here is the script I am working with right now. still figuring out how to contribute back to this project. currently running into issues with more recent verions of buildkit. tyler-lloyd@5214711

[jkroepke]

@tyler-lloyd please let me know if I can assists here. I need them soon and I would not like to copy and own docker images.

I hope @seeker89 and @skamboj are still open for the kind of feature.

[jkroepke]

Again, can I help here?

[tyler-lloyd]

@jkroepke - taking a look at your PR! thanks for picking this up!

[jkroepke]

@tyler-lloyd I found the blog artical which mention the cross OS builds for Windows. But instead using the shell scripts, I modernize the concept by using buildx bake

[tyler-lloyd]

I saw. The bake stuff is new to me so I'm interested to learn more about it. Do you have a test repository we can pull from that used your new ci tooling?

[jkroepke]

Sure:

https://github.com/cloudeteer/goldpinger/pkgs/container/goldpinger/143990577?tag=latest

ghcr.io/cloudeteer/goldpinger:latest

[tyler-lloyd]

hmm @jkroepke @skamboj I noticed the most recent version doesn't have the v prefix on the docker images? (it's 3.9.0 not v3.9.0) https://hub.docker.com/layers/bloomberg/goldpinger/3.9.0/images/sha256-955e43662647e650ef2f918f099e40bab2e0ac4d67c0855ae55652e852c581f6?context=explore

[jkroepke]

Whoops. Omit the v prefix on docker tags is very common. It's also the default behavior on the metadata-action. Sorry for this. I do not looked deeper on existing version.

In case the v prefix should be ensured, replace

goldpinger/.github/workflows/main.yml

Line 59 in 0b96e45

type=semver,pattern={{version}}

with

             type=semver,pattern={{raw}} 

Should add the v again