GithubHelp home page GithubHelp logo

Comments (4)

nils-braun avatar nils-braun commented on August 24, 2024

Do you think it would be better to delete the other calculations from the beginning in the name_to_param array or just do not add them to the kind_to_calculation_settings_mapping in the set_default_parameters function?

And how to deal with it in the from_columns method? I think here the functions should still be added if the user requests them - this is why I would not delete them from name_to_param but from kind_to_calculation_settings_mapping.

from tsfresh.

MaxBenChrist avatar MaxBenChrist commented on August 24, 2024

@jneuff looked into that. Maybe he can add some remarks as well. We moved the setup of name_to_param from the set_default_parameters to the constructor. See 8048ef4.

The current logic is "extract all the features from name_to_param for all types of time series".

If we follow that for a minimal MinimalFeatureExtractionSettings Object, then it just have a smaller name_to_param object.

from tsfresh.

jneuff avatar jneuff commented on August 24, 2024

I'd offer methods to instantiate a minimal and a full Settings object. A simple solution would be to initialize name_to_param as empty dict in the init and provide two class methods that will instantiate and configure a minimal and a full Settings object respectively. Similar to what we're doing right now with from_columns.

from tsfresh.

nils-braun avatar nils-braun commented on August 24, 2024

I am actually against doing this with another member function - because it would be something everyone has to call everytime and it would be easily forgotten. I would rather create a child class MinimalFeatureExtractionSettings and overload the constructor.

I can implement this and we can talk about it again maybe.

from tsfresh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.