it appears heyoka also has a implicit dependency on zlib but its not on the main page of pre-reqs[BUG] about heyoka

[bluescarni]

Hi @jdmairs thanks for the report.

The dependency on zlib is a workaround due to the fact that (at least some versions of) LLVM ship on Windows with CMake config package files which directly link to the z library, which typically ends up failing if zlib is not installed in a standard location. This is an issue with the LLVM build system, which in theory should take care of locating its own dependencies.

This issue was present at least in LLVM10 but perhaps it was solved eventually. Could you try commenting out lines 309 to 317 in the main CMakeLists.txt?

[jdmairs]

Hi thanks for the quick reply. I did comment out the lines and successfully generated the build files; however VS2017 15.9.24 is having alot of problems. I wrote a separate ticket for that.

…

On Thu, Jul 1, 2021 at 3:35 PM Francesco Biscani ***@***.***> wrote: Hi @jdmairs <https://github.com/jdmairs> thanks for the report. The dependency on zlib is a workaround due to the fact that (at least some versions of) LLVM ship on Windows with CMake config package files which directly link to the z library, which typically ends up failing if zlib is not installed in a standard location. This is an issue with the LLVM build system, which in theory should take care of locating its own dependencies. This issue was present at least in LLVM10 but perhaps it was solved eventually. Could you try commenting out lines 309 to 317 in the main CMakeLists.txt? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABK5H2BGOLRYTDLWGVJLXCLTVS7QHANCNFSM47VJUDIA> .

[bluescarni]

Thanks for testing out. I'll try to comment out the workaround in the build system and see how it goes then.

[bluescarni]

@jdmairs as an additional word of warning, there might be a temporary issue if you use fmt version 8 - this stems from incompatibilities between fmt and spdlog that should be shortly resolved upstream.

In the meantime, I'd advise to stick with fmt 7.

[bluescarni]

@jdmairs I have removed the zlib bits from the CMakeLists.txt in the master branch. Note that heyoka still has an indirect dependency on zlib (in the sense that LLVM depends on it), but at least now heyoka's build system is not trying to locate zlib any more.

Thanks for the report, closing for now.