GithubHelp home page GithubHelp logo

Comments (8)

bluz71 avatar bluz71 commented on June 1, 2024 1

Apologies, my bad.

I just committed a fix that should resolve this issue.

Best regards.

from vim-nightfly-colors.

pallymore avatar pallymore commented on June 1, 2024 1

awesome, thanks for the quick fix!

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on June 1, 2024 1

Hello again,

I decided to explore this issue by installinf CoC and trying to recreate your issue.
Which I am not able to do.
I too am using Neovim 0.6 (linux) with treesitter and CoC (latest release branch version as of December 8).

By default CocUnusedHighlight links to CocFadeOut which itself links to Conceal.
Commit 673d276 removed the CocUnusedHighlight group but also changed the color of Conceal to a lighter color.

My workaround for you really should not be needed, and from my testing it isn't needed. Hence, I will remove it. It will likely break your setup, but we should debug the underlying cause of your issue since I think the CocUnusedHighlight group is somehow screwed up in your setup.

In your case I suggest you run the following commands and see if they match my results:

First

Second

Third

If you don't have time to debug you could temporarily add the following to your setup to get you by:

hi link CocUnusedHighlight TSVariable

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on June 1, 2024 1

Sorry for the diversion :)

I have added the workaround back in.....and now I know about the issues of indentLine; I can keep that in the memory bank if other users encounter Conceal issues. So this little exercise is still useful to me.

In your case, I strongly suggest moving over to indent-blankline which is a much better plugin than indentLine; it is even treesitter aware. Here is my indent-blankline config.

Cheers.

from vim-nightfly-colors.

pallymore avatar pallymore commented on June 1, 2024 1

Thank you! I will switch to indent-blankline instead 😬

from vim-nightfly-colors.

pallymore avatar pallymore commented on June 1, 2024

Hi - thanks for the update.

here're my results:

CleanShot 2021-12-08 at 00 22 04

CleanShot 2021-12-08 at 00 22 22

CleanShot 2021-12-08 at 00 22 34

for some reason I have a different Conceal color 🤔

from vim-nightfly-colors.

pallymore avatar pallymore commented on June 1, 2024

OK I think i figured it out - this seems to have something to do with https://github.com/Yggdroot/indentLine

I'm getting the same color as you did as soon as I remove indentLine - could you confirm if you could reproduce the issue with that plugin?

from vim-nightfly-colors.

bluz71 avatar bluz71 commented on June 1, 2024

Yeah, I can repeat it now.

indentLine plugin completely overwrites the value of Conceal unless you set:

let g:indentLine_setColors = 0

I don't encounter this issue since I use the indent-blankline.nvim which is a much better plugin for use in Neovim. It uses virtual text for the indent guides instead of concealed text.

As for the combination of indentLine and CoC, let me think about things. I need to figure out a solution that works best for everyone. That may just be as simple as reverting my reverting.

Thanks for taking the time, I appreciate it.

from vim-nightfly-colors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.