GithubHelp home page GithubHelp logo

Comments (4)

ArcticSnowman avatar ArcticSnowman commented on May 20, 2024

This in fact breaks the GetCulprits() as you can't pass the return array around as the 'type' is not exported..

from gojenkins.

ArcticSnowman avatar ArcticSnowman commented on May 20, 2024

PR #103 to fix

from gojenkins.

supereagle avatar supereagle commented on May 20, 2024

Agree.

Seems odd to have a structure type not follow the case rules..
Also it prevent the godoc from showing it in the documentation page and you don't have a nice link from the build.GetCulprits() function definition.

Even culprit is not exported, GetCulprits() also can correctly work.

This in fact breaks the GetCulprits() as you can't pass the return array around as the 'type' is not exported..

from gojenkins.

ArcticSnowman avatar ArcticSnowman commented on May 20, 2024

OK fixed with the merge of the PR

from gojenkins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.