GithubHelp home page GithubHelp logo

Comments (1)

bobbingwide avatar bobbingwide commented on July 28, 2024

The current logic uses get_permalink( $id ) to determine the permalink.

  • When passed a post ID, get_permalink calls get_post() to access the post.
  • It then checks the post_type to determine how to create the permalink - returning the correct format for "page", "attachment" and any registered post type that's not _builtin

Everything else is treated as a "post" using the permalink_structure option.

get_permalink() invokes the 'pre_post_link' filter first ( incorrectly documented as 'Only applies to posts with post_type of 'post' ). This filter hook is not normally implemented, so the permalink structure to be used is unchanged.

And just at the end of the function it invokes the "post_link" filter, also not normally implemented.

Conclusion

We could consider implementing the "post_link" filter to null out the result when the post type is not registered. But I don't think it's necessary.

I might raise a WordPress TRAC on the docblock for 'pre_post_link' though.

from oik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.