Comments (7)
I'd rather you used git rebase and simply removed the experimental commits (after saving them to a branch). That'd leave a clean history and make it much easier to review.
The same applies to pull requests. In your last pull request, you included commits that fix your older commits. No need for that, just rebase them and organize them logically, not historically.
from smallcheck.
Rebasing a public master
branch on a origin repo would break current forks on the next pull. They would have to manually remane their current master
and sync it with the remote newly checked out branch. I also could make the default branch for this repo a new branch which then could be rebased safely, but having the name master
for a non default branch would be awkward.
For the PR I agree with you, in that case rebasing makes sense to me.
from smallcheck.
Rebasing a public master branch on a origin repo would break current forks on the next pull.
This is a non-issue. If they need to stay on top of master, they need to rebase in either case; and if not, they'll cancel their pull.
from smallcheck.
Sorry to disagree with you, but I do see this as an issue. Let me be clear, are you asking me to do this?
$ git clone feuerbach/smallcheck
$ cd smallcheck
$ git checkout -b experimental
$ git push origin experimental
$ git checkout master
$ git rebase -i v1.1.1 # Remove experimental commits
$ git push --force
from smallcheck.
Correct.
from smallcheck.
Sorry, I won't do it. I give a crap about preserving history. I wouldn't do this with any of my repos, so I'm not going start with this one.
from smallcheck.
shrug
History is fun, but keeping the repo clean is more important.
If you rebase the branch, it'd be obvious to me whether you did it right or not. I'd just look at the set of commits in the branch and check that it's the set of commits that I expect to be there.
With your current branch, it isn't obvious to either of us whether you did the right thing. You have a bunch of commits that make the changes that shouldn't have been there in the first place, then another commit hopefully reverting it to the right state. How do you expect me to review that?
from smallcheck.
Related Issues (20)
- Add 'tasty' instead of test-framework to docs as an option for running smallcheck HOT 1
- Documentation: types with >4 fields HOT 1
- Fix the tests!
- smallcheck-1.1.1 doesn't compile with current GHC head snapshot HOT 2
- Port some convenience list functions from QuickCheck HOT 2
- Serial and CoSerial instances for `Word` HOT 3
- Smallcheck defines an orphan which overlaps `Show (a -> b)` instance from base HOT 3
- Serial instance for base types HOT 2
- Show the bad tests(the ones which didn't meet the ==> condition) even on success HOT 1
- test function of Property type class is not available HOT 4
- Could not find module Numeric.Natural in GHC 7.8 HOT 1
- How to generate a non-empty list of items with a predicate (using suchThat)? HOT 2
- Smallcheck fails to build due to the Safe pragma HOT 3
- Extract Number Wrappers HOT 2
- Generically derived Serial instance for mutually recursive data type causes infinite loop HOT 2
- depth for generics is broken HOT 5
- Builf failure: Test.SmallCheck.Series: GHC.Base.MonadPlus ml HOT 4
- build errors with GHC-7.4 HOT 2
- Clarify the deprecation statement HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smallcheck.