GithubHelp home page GithubHelp logo

Comments (7)

bomberstudios avatar bomberstudios commented on July 19, 2024

That sounds awesome, and it's something I'd do myself if I had the time, so I'll happily merge a pull request with these changes from you : )

from sketch-commands.

guerrero avatar guerrero commented on July 19, 2024

Done :) #61

from sketch-commands.

bomberstudios avatar bomberstudios commented on July 19, 2024

Awesome! Will review and merge in a minute : )

from sketch-commands.

guerrero avatar guerrero commented on July 19, 2024

@bomberstudios Great! Thanks for your support, also I've seen some other changes that can be done to improve the repo and save some lines of code. Some of them are the following:

  • Delete sandbox file and modify files that uses sandbox methods
  • Remove semicolons due they are unnecesary in CocoaScript
  • Add two tasks, one to update manifest and the other one to copy this repo into your sketch plugins folder and update it when files are changed to improve development and testing

I've also other recommendations and propositions, like use dot notation to support linting tools, but I don't know if you're interested and I don't want to be like a spammer opening a lot of issues at the same time so, if you wish, I can proceed creating some issues.

Thanks!

from sketch-commands.

bomberstudios avatar bomberstudios commented on July 19, 2024

Delete sandbox file and modify files that uses sandbox methods

Just did this locally, so I'll take it and will push in a minute.

The rest look reasonable, and I'd love to get pull requests for them : )

from sketch-commands.

guerrero avatar guerrero commented on July 19, 2024

Nice! I'll create them in the next few days.

P.S. Thanks to mention me in your README's Thanks section!

from sketch-commands.

bomberstudios avatar bomberstudios commented on July 19, 2024

P.S. Thanks to mention me in your README's Thanks section!

It's the least I could do!

from sketch-commands.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.