GithubHelp home page GithubHelp logo

Comments (12)

boorik avatar boorik commented on July 18, 2024

Hmm why not. We can give it a try and look if there is no drawbacks to this. Rollback will be easy if we encounter issues.

from smartfox-haxe-client.

boorik avatar boorik commented on July 18, 2024

merged. Good job :)

from smartfox-haxe-client.

flashultra avatar flashultra commented on July 18, 2024

What was the point to remove ISFSArray and ISFSObject ? I understand about javascript API, but this cause problem on other target. At example at the moment I convert source code from AS3 to haxe and In the code it's used many times ISFSObject . I can replace it with SFSObject , but it won't be the same as documentation . At example:

  1. Flash target
    ExtensionRequest(extCmd:String, params:ISFSObject = null ....
    (*) http://docs2x.smartfoxserver.com/api-docs/asdoc/com/smartfoxserver/v2/requests/ExtensionRequest.html

  2. Java API
    ExtensionRequest(java.lang.String extCmd, com.smartfoxserver.v2.entities.data.ISFSObject params)
    (*) http://docs2x.smartfoxserver.com/api-docs/javadoc/client/sfs2x/client/requests/ExtensionRequest.html

  3. Objective-C
    *(id)requestWithExtCmd:(NSString )extCmd params:(id)params room:(id)room udp:(BOOL)udp
    (*) http://docs2x.smartfoxserver.com/api-docs/objc-doc/Classes/ExtensionRequest.html

Removing ISFSObject and ISFSArray and you create different API. I understand about javascript, but still at the moment I need to target flash and html5.

Hope so you will revert changes.

from smartfox-haxe-client.

boorik avatar boorik commented on July 18, 2024

Yes we can do something else, maybe we can do something like :
#if html5
typedef ISFSObject = SFSObject;
#else
interface ...

from smartfox-haxe-client.

flashultra avatar flashultra commented on July 18, 2024

That sounds good for me i.e. in Smartfox.hx still will wait for ISFSObject , but for JS that will be SFSObject

from smartfox-haxe-client.

boorik avatar boorik commented on July 18, 2024

Hey, I just pushed a branch named "interfaces", it compiles with flash and html5 targets (didn't try others ). I have an issue recovering policy file in flash.
Can you try it and tell me if you have this issue?
Is it working as expected for you?

from smartfox-haxe-client.

boorik avatar boorik commented on July 18, 2024

ok got the issue on my linux machine, on my windows it works with flash too.

from smartfox-haxe-client.

flashultra avatar flashultra commented on July 18, 2024

The project is still WIP, so I can't make real tests. I will update in the thread when make a test.

from smartfox-haxe-client.

flashultra avatar flashultra commented on July 18, 2024

On question about SFSObject class. There have :
public function getLong(key:String):Null < Float >
but is that correct ( i.e its Float for Long type) ? Long should be Int or maybe I'm wrong ?

from smartfox-haxe-client.

boorik avatar boorik commented on July 18, 2024

Regarding the old documentation, Java Long is haxe Float :
http://old.haxe.org/doc/java/externs

from smartfox-haxe-client.

boorik avatar boorik commented on July 18, 2024

I merged the interfaces branch in the master one.

from smartfox-haxe-client.

rewb0rn avatar rewb0rn commented on July 18, 2024

Yes I agree, using typedef for HTML5 might be the better solution, I didn't think of that!

from smartfox-haxe-client.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.