Comments (12)
Hmm why not. We can give it a try and look if there is no drawbacks to this. Rollback will be easy if we encounter issues.
from smartfox-haxe-client.
merged. Good job :)
from smartfox-haxe-client.
What was the point to remove ISFSArray and ISFSObject ? I understand about javascript API, but this cause problem on other target. At example at the moment I convert source code from AS3 to haxe and In the code it's used many times ISFSObject . I can replace it with SFSObject , but it won't be the same as documentation . At example:
-
Flash target
ExtensionRequest(extCmd:String, params:ISFSObject = null ....
(*) http://docs2x.smartfoxserver.com/api-docs/asdoc/com/smartfoxserver/v2/requests/ExtensionRequest.html -
Java API
ExtensionRequest(java.lang.String extCmd, com.smartfoxserver.v2.entities.data.ISFSObject params)
(*) http://docs2x.smartfoxserver.com/api-docs/javadoc/client/sfs2x/client/requests/ExtensionRequest.html -
Objective-C
*(id)requestWithExtCmd:(NSString )extCmd params:(id)params room:(id)room udp:(BOOL)udp
(*) http://docs2x.smartfoxserver.com/api-docs/objc-doc/Classes/ExtensionRequest.html
Removing ISFSObject and ISFSArray and you create different API. I understand about javascript, but still at the moment I need to target flash and html5.
Hope so you will revert changes.
from smartfox-haxe-client.
Yes we can do something else, maybe we can do something like :
#if html5
typedef ISFSObject = SFSObject;
#else
interface ...
from smartfox-haxe-client.
That sounds good for me i.e. in Smartfox.hx still will wait for ISFSObject , but for JS that will be SFSObject
from smartfox-haxe-client.
Hey, I just pushed a branch named "interfaces", it compiles with flash and html5 targets (didn't try others ). I have an issue recovering policy file in flash.
Can you try it and tell me if you have this issue?
Is it working as expected for you?
from smartfox-haxe-client.
ok got the issue on my linux machine, on my windows it works with flash too.
from smartfox-haxe-client.
The project is still WIP, so I can't make real tests. I will update in the thread when make a test.
from smartfox-haxe-client.
On question about SFSObject class. There have :
public function getLong(key:String):Null < Float >
but is that correct ( i.e its Float for Long type) ? Long should be Int or maybe I'm wrong ?
from smartfox-haxe-client.
Regarding the old documentation, Java Long is haxe Float :
http://old.haxe.org/doc/java/externs
from smartfox-haxe-client.
I merged the interfaces branch in the master one.
from smartfox-haxe-client.
Yes I agree, using typedef for HTML5 might be the better solution, I didn't think of that!
from smartfox-haxe-client.
Related Issues (10)
- Server communication HOT 1
- SFSArray:getBool returning null on iOS (+ suggested fix) HOT 3
- Bluebox HOT 2
- HTML5 support ? HOT 9
- Missing putText(key:String, value:String) in SFSObject
- Property iterator not found on haxe.ds.IntMap HOT 2
- Crash when using encryption (null ByteArray cast)
- Android does not receive CONNECTION_LOST event
- [HTML5] SFSDataSerializer class HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smartfox-haxe-client.