GithubHelp home page GithubHelp logo

Comments (2)

f-koehler avatar f-koehler commented on August 25, 2024

I have a question about this issue. Is crashing not what the library should do? If building with a binary fails this indicates that something went wrong, for example that the binary was not compatible, etc. Is there a scenario where we want to continue the execution of the host program? Or do you mean that we don't want the exception to be thrown by get_info<std::string>(CL_PROGRAM_SOURCE) which fails to fetch the source code that is not available? In that case one could just catch exceptions of source() and then throw a new one indicating that no source code is available, like here (something went wrong with my code indentation, I read the rules).

Maybe you need to clarify what you mean.

from compute.

kylelutz avatar kylelutz commented on August 25, 2024

Thanks for looking into this!

If program::create_with_binary() or program::build() fails, we should throw an exception (and definitely never crash). I think all that would be needed is to try to call program::source() and not print out anything if it's a binary program. And perhaps program::source() should be robust to binary programs and return an empty string in that case.

However, I only saw this once haven't been able to reproduce it since (could have just been something weird going on with my system). I'll close this for now, but if you (or anyone) is able to reproduce this, please re-open with more information about the crash.

from compute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.