GithubHelp home page GithubHelp logo

Comments (10)

mclow avatar mclow commented on July 19, 2024

Since I complained about your proposed fix, I'll take a look at this.

from dynamic_bitset.

mclow avatar mclow commented on July 19, 2024

I'm not getting these warnings with clang. I'll try with gcc.

from dynamic_bitset.

olk avatar olk commented on July 19, 2024

b2 toolset=gcc cxxflags="-std=c++17 -W -Wall -Werror" -j 32

dyn_bitset_unit_tests2.cpp:285:33: von hier erfordert
../../../boost/dynamic_bitset/dynamic_bitset.hpp:1953:57: Fehler: left shift of negative value [-Werror=shift-negative-value]
block_type const mask = (~static_cast(0) << extra_bits);

gcc -v: gcc-Version 7.2.1

from dynamic_bitset.

mclow avatar mclow commented on July 19, 2024

Must be a new warning with 7.2; I don't get them with 7.1.
/me Off to install a newer version....

from dynamic_bitset.

olk avatar olk commented on July 19, 2024

got this with gcc-6.3.0 too using the develop branch

from dynamic_bitset.

mclow avatar mclow commented on July 19, 2024

Ok - c++17 is the key.

from dynamic_bitset.

olk avatar olk commented on July 19, 2024

b2 toolset=gcc cxxflags="-std=c++11 -W -Wall -Werror" -j 32 produces the same error (Arch Linux, gcc-7.2.1)

from dynamic_bitset.

mclow avatar mclow commented on July 19, 2024

Fixed in d3eb4fa

from dynamic_bitset.

olk avatar olk commented on July 19, 2024

fix works, thx

from dynamic_bitset.

igorsugak avatar igorsugak commented on July 19, 2024

I just discovered this same bug with UBSAN:
dynamic_bitset.hpp:1943:55: runtime error: left shift of negative value -1
Thank you for fixing this!

from dynamic_bitset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.