RuntimeError: Shonan::run did not converge for given pMax about gtsam

[dellaert]

Rather than creating a file, could you try to use the code example in in test_ShonanAvaerging.py? Here is a snippet:

        measurements = []
        unit3 = gtsam.noiseModel.Unit.Create(3)
        m01 = BinaryMeasurementRot3(0, 1, Rot3.Yaw(math.radians(90)), unit3)
        m12 = BinaryMeasurementRot3(1, 2, Rot3.Yaw(math.radians(90)), unit3)
        measurements.append(m01)
        measurements.append(m12)
        obj = ShonanAveraging3(measurements)
        self.assertIsInstance(obj, ShonanAveraging3)
        initial = obj.initializeRandomly()
        _, cost = obj.run(initial, min_p=3, max_p=5)
        self.assertAlmostEqual(cost, 0)

[anilesec]

Thanks for the response! I have tried this. But I am getting the following error

I think it could be mismatch in gtsam version (I installed gtsam using pip as "pip install gtsam" )

[dellaert]

Yeah. Try uninstalling and pip install gtbook

[anilesec]

I created a new conda env (python 3.6.9) and installed gtbook (pip install gtbook).

I still get the same error:

[dellaert]

Dang,. Sorry this is happening to you. I will investigate but might need the 4.2 release.

[anilesec]

My bad! May I ask when the 4.2 release is planned? Otherwise, if I can somehow figure out how to set the measurements value in the input(g2o) file, perhaps I can run "ShonanAveragingCLI.py" script. Any help to set the 21 measurements values for a custom dataset would be a great help for my research.

Thank you very much for your precious time and effort!

[dellaert]

Actually, it is related to recent changes in the wrapper. There was an old way to do this, and I tried it in this notebook, and it works. Here is the code snippet:

%pip -q install gtbook

import math
import gtsam
from gtsam import BinaryMeasurementRot3, Rot3, ShonanAveraging3, BinaryMeasurementsRot3

measurements = BinaryMeasurementsRot3()
unit3 = gtsam.noiseModel.Unit.Create(3)
m01 = BinaryMeasurementRot3(0, 1, Rot3.Yaw(math.radians(90)), unit3)
m12 = BinaryMeasurementRot3(1, 2, Rot3.Yaw(math.radians(90)), unit3)
measurements.append(m01)
measurements.append(m12)
obj = ShonanAveraging3(measurements)
assert isinstance(obj, ShonanAveraging3)
initial = obj.initializeRandomly()
result, cost = obj.run(initial, min_p=3, max_p=5)
assert cost < 1e-4
print(result)

I will close this issue but try to make sure the "list" way works in 4.2.

[anilesec]

Great! It works now :) Thanks a lot!

[anilesec]

  measurements = []
  unit3 = gtsam.noiseModel.Unit.Create(3)
  m01 = BinaryMeasurementRot3(0, 1, Rot3.Yaw(math.radians(90)), unit3)
  m12 = BinaryMeasurementRot3(1, 2, Rot3.Yaw(math.radians(90)), unit3)
  measurements.append(m01)
  measurements.append(m12)
  obj = ShonanAveraging3(measurements)
  self.assertIsInstance(obj, ShonanAveraging3)
  initial = obj.initializeRandomly()
  _, cost = obj.run(initial, min_p=3, max_p=5)
  self.assertAlmostEqual(cost, 0)

This snippet does not seem to work in 4.2 release.

Also how to select the noise model for the real-world dataset? Is there an example?