Activate the CI about components

[mirkobrombin]

Just for confirmation, has the PAT been set? If so, the next run should be working just fine now 🤞

I’ll set this asap.

[koplo199]

I've detailed the choice for this in bottlesdevs/Bottles#2223 (comment) but the tldr is that in a later date when/if auto-merge is enabled, it will be needed because the GitHub Bot cannot approve its own PR (no one can), so the PR needs to be created by another entity

[mirkobrombin]

the CI is active already, it's just failing https://github.com/bottlesdevs/components/actions/runs/3538533089

[koplo199]

Oh it's failing because a ci branch has been created manually just before merging. The timing was so perfect I though it was an intentional (and creative) way of blocking the CI. Just deleting this branch will solve the issue.

The branch naming prefix ci is reserved for the CI, but if it needs to be changed for whatever reason it could be done by editing:

components/.github/workflows/pull-components.yml

Lines 11 to 15 in 2275e19

	PR_BRANCH: ci/${{ github.ref_name }}
	concurrency:
	# Github Actions does not support ${{ env.PR_BRANCH }} as group name...
	group: ci/${{ github.ref_name }}

[mirkobrombin]

Oh this makes sense 😂

[koplo199]

Just for confirmation, has the PAT been set? If so, the next run should be working just fine now 🤞

[koplo199]

Seem like it hasn't, step by step guide:

Yay merged 🎉

Is the PAT already set? If it is not configured pull requests won't be created, to configure it:

From any account (could very well be a newly created burner account like @bottlesdevs-components[BOT] or something) do
(Account) Settings -> Developer settings -> Personal access tokens -> Tokens (classic) -> Generate new token (classic) -> public_repo (No expiration)

Then copy paste it into
(Repository) Settings -> Secrets -> Actions -> New repository secret -> Name = PAT

Originally posted by @koplo199 in #182 (comment)

[mirkobrombin]

Just a question: why not using the default GitHub bot?

[mirkobrombin]

In retrospect it might make sense to approve them manually 🤔

[koplo199]

In retrospect it might make sense to approve them manually 🤔

I agree, additionally if the idea of auto-approval is dropped then the PAT is no longer necessary, so

components/.github/workflows/pull-components.yml

Line 251 in 2275e19

token: ${{secrets.PAT}}

could be replaced by ${{secrets.GITHUB_TOKEN}} and it will work right away

[koplo199]

As the CI made its first PR #195, I guess this issue could be closed safely 👍