GithubHelp home page GithubHelp logo

Comments (11)

hugovk avatar hugovk commented on September 29, 2024

Yes, that stuff should be fine.

How do you normally run pngcrush? Can you give an example command?

from botwiki.org.

stefanbohacek avatar stefanbohacek commented on September 29, 2024

I believe this will answer your question: #6 :-)

The reason for closing this was actually a bit misguided. I thought it would require keeping source images and saving optimized images separately, which is how I normally keep things (just in case, I suppose). It would make sense to just overwrite the screenshots in our case, so I think I'll look into reopening that issue.

Either way, I usually just use common/default values.

from botwiki.org.

hugovk avatar hugovk commented on September 29, 2024

Whilst looking at tags, should we change the case at all?

Does it matter if their order is changed when deduping? Do we want a specific order?

from botwiki.org.

stefanbohacek avatar stefanbohacek commented on September 29, 2024

How about doing something like this (pseudocode):

switch (bot.type):
  case 'twitterbot':
    tags = ['twitter', 'twitterbot']
  break
// etc for other networks, then later
tags += user_submitted_tags 
          + (bot.is_opensource ? ['open source', 'opensource'] : ) 
          + author_twittername
// finally
tags.dedupe

I don't think the tag order particularly matters, but I would rather keep the order, which has been something like what the code above would produce.

This actually reminds me, we need to ask about the language for open source bots!

Oh and I'd definitely use lowercase. Thank you!

from botwiki.org.

stefanbohacek avatar stefanbohacek commented on September 29, 2024

I added a question "If the bot is open source, what language was used to write it? (Or just leave blank.)".

from botwiki.org.

hugovk avatar hugovk commented on September 29, 2024

Did the new question shift the Added column one to the right? If so, I need to update for that too :)

from botwiki.org.

hugovk avatar hugovk commented on September 29, 2024

All but the pngcrush/Trimage addressed in #41.

It doesn't looks like Trimage has any Windows binaries, but pngcrush is more platform-independent.

Default options don't trim much:

  • The original GenerateACat.png from botshotter.py is 440 KB.
  • The one you optimised (with trimage?) and updated in the repo is 386 KB.
  • The pngcrushed one is 435 KB.

GenerateACat.botshotter.png:
generateacat botshotter


GenerateACat.trimage.png:
generateacat trimage


GenerateACat.pngcrush.png:
generateacat pngcrush

from botwiki.org.

stefanbohacek avatar stefanbohacek commented on September 29, 2024

@hugovk Hmm, it looks like adding a new question adds a new column at the end, but before any manually added columns.

I just added a test submission, feel free to check it out and delete when done.

from botwiki.org.

hugovk avatar hugovk commented on September 29, 2024

Hmm, it looks like adding a new question adds a new column at the end, but before any manually added columns.

We'll have to remember that in future.

I just added a test submission, feel free to check it out and delete when done.

Test submission seemed to be processed okay. Deleted.

from botwiki.org.

hugovk avatar hugovk commented on September 29, 2024

The Trimage shows it using OptiPNG, I'll look into that. https://github.com/Kilian/Trimage/blob/master/src/trimage/trimage.py#L435

from botwiki.org.

stefanbohacek avatar stefanbohacek commented on September 29, 2024

@hugovk Awesome, thank you!

from botwiki.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.