Comments (4)
Thanks for the issue, @ddovod. This is added in 379d085
A couple things:
- When backgrounding and then foregrounding, there was a crash when setting
layoutInDisplayCutoutMode
in_glfmSetFullScreen
. To avoid this,layoutInDisplayCutoutMode
is set once on startup. - Safe insets are only used for fullscreen mode, otherwise system window insets are used.
I think this covers all the cases, but feel free to create another issue if you see any problems.
from glfm.
This change makes handling notched layout significantly less convenient for certain apps, since it forces the application itself to handle notches and safe insets. I would like to be able to specify the type of notch behavior, or at least disable this code and use the default (black bars around notch).
@brackeen Would you accept a PR to make this behavior configurable? What would be the best way to achieve this - through a new surface configuration option, or a #define NOTCH_NO_SHORT_EDGES
switch?
from glfm.
@Anuken I'm not sure "black bars around notch" would work on iOS, because the App Store requires notch support. It's probably better to handle notches on the app level, but having adding Android-only switch would be fine.
from glfm.
the App Store requires notch support
Strange, I had an app on iOS with no notch support for more than a year, and the review system didn't have any issue with it. In fact, I even had screenshots with black bars visible on the store.
It's probably better to handle notches on the app level
That's fair, but the app I'm using GLFM for currently doesn't target iOS, so black bars on Android are acceptable.
from glfm.
Related Issues (20)
- Readme improvement suggestions HOT 1
- Android: Fix issue with chrome insets when rotating
- iOS: Add mouse hover support (iPadOS 13.4)
- Using glfm on Android with AIDE app HOT 1
- Keyboard Input HOT 2
- iOS: Add support for GCKeyboard on iOS 14 HOT 1
- Web: Add support for sensors (via Emscripten)
- Build the GLFM examples with Android Studio 4 HOT 1
- how about MacOS HOT 5
- iOS: Consider macOS Catalyst support
- Glfm
- Support something like UIImpactFeedbackGenerator (Device Vibrations) HOT 4
- Context/Edit Menu Support HOT 2
- Dotnet 6.0 ( wasm tool ) glfm on Webassembly
- Leave app? HOT 6
- Background flickers first few moments of the app HOT 1
- Add Support For Visual Studio
- GLFMDepthFormat24 is a confusing name for Metal HOT 1
- sorry...
- Targeting API 21 on emulator crashes in glfm__getSystemWindowInsets(). HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glfm.