Hook errors does not stop pre-commit hook with an error about composer-git-hooks

[BrainMaestro]

Hi @bertrandjamin thanks for the detailed bug report. You're right, this seems like an oversight. set -e could be a choice, but it seems to have many drawbacks. This specific issue was fixed in #106, I was supposed to make a release, but other things came up. I will try to make a new release soon. You can use dev-master in the meantime to confirm that it has the expected behavior

[Shohoo]

"config": { "stop-on-failure": ["pre-commit"] }, "pre-commit": [ "echo committing as $(git config user.name)", "composer run phpstan", "composer run phpstan-generate-baseline" ]

still passes

[bertrandjamin]

Hi @BrainMaestro,

Thanks for your answer and for the link on the -eoption drawbacks 👍
I was not aware of those "complications" ^^

The && solution seems perfect and I will use it right after your next release !

[Asenar]

Hi,

I strongly suggest to add in documentation than the hooks behaviour is not «usual» and in case of many hooks, pre hooks will pass.

the && hack seems to fix the problem, but why not generate the hooks with something like ./command1 && ./command2 || exit 1 ?

[BrainMaestro]

A new release has been made which solves this. Feel free to reopen if it reoccurs