Build issue related to MultiThreaderBase.h about brainstools

[hjmjohnson]

I'm working with the TBB development team to fix issues with TBB installs. See #423

[tashrifbillah]

I wish I tried it earlier. I didn't see a commit was added addressing my issue. However, it didn't work:

Performing C++ SOURCE FILE Test CXX_HAS_DISABLE_OPTIMIZATION_FLAG failed with the following output:
Change Dir: /home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp

Run Build Command:"/usr/bin/gmake" "cmTC_8a147/fast"
gmake[3]: Entering directory `/home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp'
/usr/bin/gmake -f CMakeFiles/cmTC_8a147.dir/build.make CMakeFiles/cmTC_8a147.dir/build
gmake[4]: Entering directory `/home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_8a147.dir/src.cxx.o
/usr/bin/c++    -Wall -Wcast-align -Wdisabled-optimization -Wextra -Wformat=2 -Winvalid-pch -Wno-format-nonliteral -Wpointer-arith -Wshadow -Wunused -Wwrite-strings -funit-at-a-time -Wno-strict-overflow -Wno-deprecated -Wno-invalid-offsetof -Woverloaded-virtual -Wstrict-null-sentinel  -Wno-array-bounds -fPIC      -Wall -Wcast-align -Wdisabled-optimization -Wextra -Wformat=2 -Winvalid-pch -Wno-format-nonliteral -Wpointer-arith -Wshadow -Wunused -Wwrite-strings -funit-at-a-time -Wno-strict-overflow -Wno-deprecated -Wno-invalid-offsetof -Woverloaded-virtual -Wstrict-null-sentinel -DCXX_HAS_DISABLE_OPTIMIZATION_FLAG   -std=c++11 -o CMakeFiles/cmTC_8a147.dir/src.cxx.o -c /home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp/src.cxx
/home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp/src.cxx:1:1: error: expected unqualified-id before ‘-’ token
 -O0
 ^
gmake[4]: *** [CMakeFiles/cmTC_8a147.dir/src.cxx.o] Error 1
gmake[4]: Leaving directory `/home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp'
gmake[3]: *** [cmTC_8a147/fast] Error 2
gmake[3]: Leaving directory `/home/tb571/BRAINSTools/build/BRAINSTools-build/CMakeFiles/CMakeTmp'

Source file was:
-O0

[tashrifbillah]

ping .. @hjmjohnson

[hjmjohnson]

@tashrifbillah I can not replicate your issue. It looks like a compiler configuration problem. What OS, compiler, environment are you using?

[tashrifbillah]

Centos 7
cmake version 3.11.4

gmake --version
GNU Make 3.82
Built for x86_64-redhat-linux-gnu
Copyright (C) 2010  Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

[tashrifbillah]

By the way, I am using the default configuration.

[tashrifbillah]

Hi @hjmjohnson , where do we stand in diagnosing/solving this issue? Did we find out what is causing
error: expected unqualified-id before ‘-’ token ?

[tashrifbillah]

@hjmjohnson , I may have found a solution for my issue. Which version of cmake are you using? Previously, I was using 3.11.4 and that was yielding the above error.

However, when I updated to 3.14.2 (the latest), the error seems to disappear. Does it sound reasonable?

In brief, I am building against master branch on a Centos7 machine.

[hjmjohnson]

Perhaps. I don’t do exhaustive testing on all Cmake versions.

…

Sent from my iPhone

On Apr 18, 2019, at 11:22 AM, Tashrif Billah ***@***.***> wrote: @hjmjohnson , I may have found the solution for my issue. Which version of cmake are you using? Previously, I was using 3.11.4 and that was yielding the above error. However, when I updated to 3.14.2 (the latest), the error seems to disappear. Does it sound reasonable? In brief, I am building against master branch on a Centos7 machine. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.