GithubHelp home page GithubHelp logo

Comments (5)

Beastw00d avatar Beastw00d commented on September 28, 2024

braintree2

This is what I mean by unclickable.

from braintree-web-drop-in.

crookedneighbor avatar crookedneighbor commented on September 28, 2024

Do you have a staging site we can examine? Or a sample site on Github that reproduces the behavior?

from braintree-web-drop-in.

Beastw00d avatar Beastw00d commented on September 28, 2024

I don't. Ill try wire one up today.

from braintree-web-drop-in.

Beastw00d avatar Beastw00d commented on September 28, 2024

@crookedneighbor I've made a sample of what we are trying to achieve.

  1. Code: https://github.com/Beastw00d/beastw00d.github.io/blob/master/index.html
  2. Page: https://beastw00d.github.io/

Unfortunately this doesn't recreate the issue because it only happens when there is at least one saved credit card and I would have to set up a server to do that. I've started to think it is happening because the modal is hidden away (loaded in DOM) and the drop-in UI is created on that hidden modal right on the page load. I've been able to fix it in the real code by wiring up the create on the modal opening. The only problem with this is it makes the modal jump in size because it will take half a second start loading.
$('#braintree.modal').one('shown.bs.modal', function() { var button = document.querySelector('#submit-button'); braintree.dropin.create({..}); });

With that being said do you think this is improper use of the drop-in UI and more of an issue with using bootstrap/modals and that I should close the issue?

from braintree-web-drop-in.

crookedneighbor avatar crookedneighbor commented on September 28, 2024

Thanks for creating the page. I used Chrome dev tools to insert a client token with saved payment methods to test it.

Okay, so I think the problem is in the transition helper library: https://github.com/braintree/braintree-web-drop-in/blob/7b96efab4d64e8257d504f11b7195e2a540f14e4/src/lib/transition-helper.js

I think that since you have the modal hidden, the loading div never gets properly cleaned up. We'll look into fixing this. Thanks for reporting it!

from braintree-web-drop-in.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.