username with capital letters about api_sdk

[hamishmorgan]

Thanks for raising this issue @jgongil

Usernames are supposed to be case-insensitive in the platform so generally it shouldn't matter. The problem is in this project we are lowercasing it, but then comparing to the original case. The solution is to ensure comparisons are case-insensitive. Specifically here:

api_sdk/bwproject.py

Line 62 in a51c133

elif user["username"] == username:

If you've got time to PR a fix I'll be happy to merge it. Otherwise I'll ask someone to take a look soon.

[jgongil]

Many thanks for your help @hamishmorgan
I got around it by changing the comparison in _test_auth(self, username, token) as below, but at the same time I had to force/ensure that the BWUser is created with username in lower case.

def _test_auth(self, username, token): ... elif user["username"].lower() == username: #JG[20180904]: JSON can contain username in capital letters

[hamishmorgan]

Why not lower-cased both sides?

elif user["username"].lower() == username.lower()

That way people can use whatever case they like, and it just ignores it during comparison.

[jgongil]

Hi, yes we can, but that requires not only changing _test_auth but also:
_read_auth which is also doing if username in user_tokens (mixed case vs lower case)