GithubHelp home page GithubHelp logo

Comments (3)

iccub avatar iccub commented on June 10, 2024

Related PR: https://github.com/brave/browser-ios/pull/1633

from brave-ios.

kylehickinson avatar kylehickinson commented on June 10, 2024

We need to know where DuckDuckGo copy is going to go as well as if the popup will show up on the empty-private tabs tray (i.e. where the user sees the private-mode copy now) or still on the users first private tab

Simulator Screen Shot - iPhone 8 - 2018-09-27 at 15.52.09.png

from brave-ios.

kylehickinson avatar kylehickinson commented on June 10, 2024

Spoke to James: DDG callout will still happen on the new tab, DDG copy will appear at the bottom of the favourites list regardless of if it is not visible (too many favourites)

from brave-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.