Please file any reports of issues and/or bugs to the GitHub Repository!
If you like this addon and want to support the development of it, you can do so here:
Extended Character Stats: A WoW Classic addon
License: MIT License
Please file any reports of issues and/or bugs to the GitHub Repository!
If you like this addon and want to support the development of it, you can do so here:
Date: 2020-05-24 13:58:01
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\ExtendedCharacterStats\ECS.lua line 46:
attempt to index local 'ecs' (a nil value)
Debug:
ExtendedCharacterStats\ECS.lua:46:
ExtendedCharacterStats\ECS.lua:41
ExtendedCharacterStats\ECS.lua:31:
ExtendedCharacterStats\ECS.lua:28
Locals:
ecs = nil
defaultProfile =
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
AtlasLootClassic, vv1.5.1
AtlasLootClassicData, vv1.5.1
AtlasLootClassicDungeonsAndRaids, vv1.5.1
ClassicCastbars, vv1.3.6
ClassicCastbarsOptions, v
ClickLinks, v1.0.8
DBMCore, v1.13.45
DBMDefaultSkin, v
DBMStatusBarTimers, v
Details, v
DetailsStreamer, v
DetailsTinyThreat, v
Enchantrix, v8.2.6428 (SwimmingSeadragon)
EnchantrixBarker, v8.2.6469 (SwimmingSeadragon)
ExtendedCharacterStats, v2.4.2
SlideBar, v8.2.6375 (SwimmingSeadragon)
Stubby, v8.2.6376 (SwimmingSeadragon)
BlizRuntimeLib_enUS v1.13.4.11304
(ck=252)
v2.4.2 , also happened with v2.4.0
Hi, I believe that the increased critical chance for Holy spells in the Holy tree for Priests is not being added to the overall Holy crit chance found in the ECS. Could you take a look at that?
Best regards, Björn
The spell crit stat for fire spells isn't taking talents into account. There should be an extra 6% crit due to the talent "critical mass".
v2.3.0
Arcane Instability (crit rate) and Arcane Focus (arcane hit rate) aren't reflected in ECS
v2.1.4
There is 6 lua messages errors after launch.
Settings doesn't work and give two differents errors.
Note : Before upgrade to 2.4.3 version I delete cache and WTF folders
Message: ...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:12: Cannot find a library instance of "CallbackHandler-1.0".
Time: Mon May 25 10:11:29 2020
Count: 1
Stack: ...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:12: Cannot find a library instance of "CallbackHandler-1.0".
[C]: in function error'
...dOns\ExtendedCharacterStats\Libs\LibStub\LibStub.lua:23: in function LibStub'
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:12: in main chunk
Locals: (*temporary) = "Cannot find a library instance of "CallbackHandler-1.0"."
Message: ...eConfigECS-3.0\AceConfigCmd-3.0\AceConfigCmd-3.0.lua:17: Cannot find a library instance of "AceConfigRegistryECS-3.0".
Time: Mon May 25 10:11:29 2020
Count: 1
Stack: ...eConfigECS-3.0\AceConfigCmd-3.0\AceConfigCmd-3.0.lua:17: Cannot find a library instance of "AceConfigRegistryECS-3.0".
[C]: in function error'
...dOns\ExtendedCharacterStats\Libs\LibStub\LibStub.lua:23: in function LibStub'
...eConfigECS-3.0\AceConfigCmd-3.0\AceConfigCmd-3.0.lua:17: in main chunk
Locals: (*temporary) = "Cannot find a library instance of "AceConfigRegistryECS-3.0"."
Message: ...gECS-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:8: Cannot find a library instance of "AceConfigRegistryECS-3.0".
Time: Mon May 25 10:11:29 2020
Count: 1
Stack: ...gECS-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:8: Cannot find a library instance of "AceConfigRegistryECS-3.0".
[C]: in function error'
...dOns\ExtendedCharacterStats\Libs\LibStub\LibStub.lua:23: in function LibStub'
...gECS-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:8: in main chunk
Locals: (*temporary) = "Cannot find a library instance of "AceConfigRegistryECS-3.0"."
Message: ...aracterStats\Libs\AceConfigECS-3.0\AceConfig-3.0.lua:15: Cannot find a library instance of "AceConfigRegistryECS-3.0".
Time: Mon May 25 10:11:29 2020
Count: 1
Stack: ...aracterStats\Libs\AceConfigECS-3.0\AceConfig-3.0.lua:15: Cannot find a library instance of "AceConfigRegistryECS-3.0".
[C]: in function error'
...dOns\ExtendedCharacterStats\Libs\LibStub\LibStub.lua:23: in function LibStub'
...aracterStats\Libs\AceConfigECS-3.0\AceConfig-3.0.lua:15: in main chunk
Locals: (*temporary) = "Cannot find a library instance of "AceConfigRegistryECS-3.0"."
Message: (null)
Time: Mon May 25 10:11:30 2020
Count: 23
Message: ...Ons\ExtendedCharacterStats\Modules\Config\Config.lua:27: Cannot find a library instance of "AceConfigECS-3.0".
Time: Mon May 25 10:11:31 2020
Count: 1
Stack: ...Ons\ExtendedCharacterStats\Modules\Config\Config.lua:27: Cannot find a library instance of "AceConfigECS-3.0".
[C]: in function error'
...dOns\ExtendedCharacterStats\Libs\LibStub\LibStub.lua:23: in function LibStub'
...Ons\ExtendedCharacterStats\Modules\Config\Config.lua:27: in function CreateWindow'
...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:84: in function CreateWindow'
Interface\AddOns\ExtendedCharacterStats\ECS.lua:73: in function <Interface\AddOns\ExtendedCharacterStats\ECS.lua:71>
Interface\AddOns\ExtendedCharacterStats\ECS.lua:35: in function <Interface\AddOns\ExtendedCharacterStats\ECS.lua:28>
Locals: (*temporary) = "Cannot find a library instance of "AceConfigECS-3.0"."
Message: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:53: attempt to index global 'ECSConfigFrame' (a nil value)
Time: Mon May 25 10:11:40 2020
Count: 1
Stack: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:53: attempt to index global 'ECSConfigFrame' (a nil value)
...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:53: in function <...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:52>
Locals: (*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'ECSConfigFrame' (a nil value)"
Message: ...Ons\ExtendedCharacterStats\Modules\Config\Config.lua:183: attempt to index global 'ECSConfigFrame' (a nil value)
Time: Mon May 25 10:17:22 2020
Count: 1
Stack: ...Ons\ExtendedCharacterStats\Modules\Config\Config.lua:183: attempt to index global 'ECSConfigFrame' (a nil value)
...Ons\ExtendedCharacterStats\Modules\Config\Config.lua:183: in function ToggleWindow'
Interface\AddOns\ExtendedCharacterStats\ECS.lua:126: in function `?'
Interface\FrameXML\ChatFrame.lua:4690: in function ChatEdit_ParseText'
Interface\FrameXML\ChatFrame.lua:4351: in function ChatEdit_SendText'
Interface\FrameXML\ChatFrame.lua:4387: in function ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>
Locals: self =
{On my mage, the ECS pane, under "Spell" shows "15.97%" crit.
But under "Spell Bonus", Frost Crit (and indeed crit for all other schools of magic) is listed as "12.97%."
Edit: It appears that GetSpellCritChance does not account for talents. Arcane Instability (+3 crit chance) is not included.
Hi,
this could Maybe a besster way to detect if a set with Bonus is equipped and does not Need any local strings set names:
local itemSets = {
["StormrageRaiment"] = {
[16899] = true,
[16900] = true,
[16901] = true,
[16902] = true,
[16903] = true,
[16904] = true,
[16897] = true,
[16898] = true
},
["VestmentsOfTranscendence"] = {
[16919] = true,
[16920] = true,
[16921] = true,
[16922] = true,
[16923] = true,
[16924] = true,
[16925] = true,
[16926] = true
},
["Zul_DRUID"] = {
[19613] = true,
[19955] = true,
[19840] = true,
[19839] = true,
[19838] = true
},
["Zul_SHAMAN"] = {
[19609] = true,
[19956] = true,
[19830] = true,
[19829] = true,
[19828] = true
},
["Zul_PALADIN"] = {
[19952] = true,
[19588] = true,
[19827] = true,
[19826] = true,
[19825] = true
}
}
local function IsSetBonusActive(setname, bonusLevel)
local set = itemSets[setname]
if not set then return false end
local pieces_equipped = 0
for slot = 1, 17 do
local itemID = GetInventoryItemID("player", slot)
if set[itemID] then pieces_equipped = pieces_equipped + 1 end
end
return (pieces_equipped >= bonusLevel)
end
And here you can check it:
local function _HasSetBonusModifierMP5()
if classId == ClassIndex.PRIEST then
return IsSetBonusActive("VestmentsOfTranscendence", 3)
elseif classId == ClassIndex.DRUID then
return IsSetBonusActive("StormrageRaiment", 3)
end
return false
end
local function MP5FromItems()
local mp5 = 0
local classname = select(2, UnitClass("Player"))
for i = 1, 18 do
local itemLink = GetInventoryItemLink("player", i)
if itemLink then
local stats = GetItemStats(itemLink)
if stats then
local statMP5 = stats["ITEM_MOD_POWER_REGEN0_SHORT"]
if statMP5 then
mp5 = mp5 + statMP5 + 1
end
end
end
end
-- check if Zul Gurub Set Bonus is active
if classId == ClassIndex.DRUID or classId == ClassIndex.PALADIN or classId == ClassIndex.SHAMAN then
if IsSetBonusActive("Zul_" .. classname, 2) then
mp5 = mp5 + 4
end
end
return mp5
end
The miss chance calculations for melee and ranged are incorrect. They assume use a miss chance against bosses of 8%, but it should be 9%.
The function _GetMissChanceByDifference()
in Data.lua uses the following formula: 6 + (defenseValue - weaponSkill - 10) * 0.4
. The 6 should be a 7.
https://vanilla-wow.fandom.com/wiki/Hit
https://www.wowhead.com/news=292085/hit-cap-in-classic-wow-clarifications
I'm using version 2.1.4.
I created a new character, a night elf druid, and got this bug upon first login.
2.4.0
Date: 2020-05-27 07:58:16
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\ExtendedCharacterStats\ECS.lua line 45:
attempt to index local 'ecs' (a nil value)
Debug:
ExtendedCharacterStats\ECS.lua:45:
ExtendedCharacterStats\ECS.lua:41
ExtendedCharacterStats\ECS.lua:31:
ExtendedCharacterStats\ECS.lua:28
Locals:
ecs = nil
defaultProfile = <table> {
general = <table> {
}
profile = <table> {
}
}
(*temporary) = <table> {
private = <table> {
}
version = 2
GetDefaultProfile = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\Profile.lua:141
}
(*temporary) = <table> {
general = <table> {
}
profile = <table> {
}
}
(*temporary) = "attempt to index local 'ecs' (a nil value)"
Profile = <table> {
private = <table> {
}
version = 2
GetDefaultProfile = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\Profile.lua:141
}
i18n = <table> {
UseGerman = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\i18n\de.lua:6
LoadLanguageData = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\i18n\i18n.lua:6
UseEnglish = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\i18n\en.lua:6
SetLanguage = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\i18n\i18n.lua:24
private = <table> {
}
translate = <function> defined @Interface\AddOns\ExtendedCharacterStats\Modules\i18n\i18n.lua:30
}
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
AtlasLootClassic, vv1.5.1
AtlasLootClassicData, vv1.5.1
AtlasLootClassicDungeonsAndRaids, vv1.5.1
AtlasLootClassicMaps, vv1.0.0
AucAdvanced, v8.2.6430 (SwimmingSeadragon)
AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
AucStatSimple, v8.2.6399 (SwimmingSeadragon)
AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
BagBrother, v
BankStack, vv11302.0
Bartender4, v4.9.0
BeanCounter, v8.2.6434 (SwimmingSeadragon)
BuffOwner, v1.1
ClassicAuraDurations, v1.13.56
ClassicCastbars, vv1.3.6
ClassicCastbarsOptions, v
ClassTrainerPlus, v0.7-beta
Combuctor, v8.3.2
DBMCore, v1.13.45
DBMDefaultSkin, v
DBMStatusBarTimers, v
EasyFishingClassic, v1.2
Enchantrix, v8.2.6428 (SwimmingSeadragon)
EnchantrixBarker, v8.2.6469 (SwimmingSeadragon)
ExtendedCharacterStats, v2.4.0
SlideBar, v8.2.6375 (SwimmingSeadragon)
Stubby, v8.2.6376 (SwimmingSeadragon)
BlizRuntimeLib_enUS v1.13.4.11304 <none>
(ck=489)
Reported on Curseforge:
Hello! Thank-you for maintaining this mod, it's super helpful!
Just a quick note re mages. If a mage has selected Arcane Instability (in the arcane tree), then only >the 3% crit is being added. The spell damage increase of 3% seems to be missing from what I can >see.
Cheers
v2.4.4
Weapon skills from items isn't included at all and neither is the base weapon skill.
You get 0.04%
hit and crit for each point: https://classic.wowhead.com/guides/classic-wow-stats-and-attributes-overview#weapon-skill
Humans have +5 weapon skill bonuses to Swords and Maces, both 1-hand and 2-hand;
Dwarves have +5 weapon skill bonus to Guns;
Orcs have +5 weapon skill bonuses to Axes, both 1-hand and 2-hand;
Trolls have +5 weapon skill bonuses to Bows and Thrown Weapons.
v2.0.0
First, thanks for this fresh addon !
I searched for a french version but i can't find it, probably it doesn't exist ? =p
So I made some modifications to translate it into french.
This is the link to my french version ! (from google drive) :)
Game Version : 1.13.4.33920
ECS Version : 2.2.1
Cheers !
PS: I added my nickname to the readme and the .toc file ^^''
This button is provided by Leatrix Plus (Classic) Addon.
https://www.curseforge.com/wow/addons/leatrix-plus-classic
after a certain version (unsure which, since i haven't updated in a while), the anchor for the stats window seems to have changed to PaperDollFrame, misplacing it if PaperDollFrame is moved in any way.
as comparison, it looks fine on v2.3.0 -- going by the version label on curseforge
version 2.4.4
Since you made the new interface, the shadow damage figure only shows to two digit places. So shows 425 as 42, make the window size bigger.
CBA to screenshot - Maybe test before you publish updates?
v2.3.0
Stats for melee and range attackpower would be interesting to see and fair since spellpower is already included.
Tooltips for each stat would be very helpful to understand each value.
Block from Gear / Set Bonuses
Block from STR
Crit from Gear
Crit from Agi, Str, Int etc.
Would be awesome.
Implement the addOn to correctly display MP5 While Casting when you have Tier 2 bonuses from Blackwing Lair. (3-piece Priest, for example)
Receive the following error :
Date: 2020-05-24 11:14:20
ID: 3
Error occured in: Global
Count: 1
Message: ..\AddOns\ExtendedCharacterStats\ECS.lua line 129:
attempt to call upvalue 'i18n' (a table value)
Debug:
[C]: ?
ExtendedCharacterStats\ECS.lua:129: ?()
..\FrameXML\ChatFrame.lua:4690:
..\FrameXML\ChatFrame.lua:4637
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:4351: ChatEdit_SendText()
..\FrameXML\ChatFrame.lua:4387: ChatEdit_OnEnterPressed()
[string ":OnEnterPressed"]:1:
[string ":OnEnterPressed"]:1
Locals:
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
AdiBags, vDEV
AtlasLootClassic, vv1.5.1
AtlasLootClassicData, vv1.5.1
AtlasLootClassicDungeonsAndRaids, vv1.5.1
AucAdvanced, v8.2.6430 (SwimmingSeadragon)
AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
AucScanData, v8.2.6365 (SwimmingSeadragon)
AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
AucStatSimple, v8.2.6399 (SwimmingSeadragon)
AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
BagBrother, v
BeanCounter, v8.2.6434 (SwimmingSeadragon)
ClassicCastbars, vv1.3.6
ClassicCastbarsOptions, v
ClassicHealPrediction, vv1.6.6
D4KiRHealerProtection, v5.7 Release
DBMCore, v1.13.45
DBMDefaultSkin, v
DBMStatusBarTimers, v
Decursive, v2.7.7
Details, v
DetailsStreamer, v
DetailsTinyThreat, v
Elephant, v1.13.3d
Enchantrix, v8.2.6428 (SwimmingSeadragon)
EnchantrixBarker, v8.2.6469 (SwimmingSeadragon)
ExtendedCharacterStats, v2.2.1
FishingBuddy, v0.7.3 Beta 5
GatherMate2, v1.45.5
GSE, v2.5.5
GSEGUI, v2.5.5
GSELDB, v2.5.5
Healium, v
honorspy, v1.7.3
Informant, v8.2.6374 (SwimmingSeadragon)
LeatrixMaps, v1.13.63
LeatrixPlus, v1.13.63
MacroTalkClassic, v1.1.1
NovaWorldBuffs, v1.53
NPCRPGossipClassic, v1.0.3
PowerAuras, v4.31.0
QoLClassicHeals, v17
QoLCore, v14
Questie, v5.10.3
Recount, vv1.13.4b
ShowMeMyHeal, v0.6.1
SlideBar, v8.2.6375 (SwimmingSeadragon)
Spy, v1.0.27
Stubby, v8.2.6376 (SwimmingSeadragon)
ThreatClassic2, v2.19
totalRP3, v1.6.11
totalRP3Data, v
TwitchEmotes, vv2
VendorPrice, v1.3.5
Wardrobe, v2.0.0
WeakAuras, v2.17.5
BlizRuntimeLib_enUS v1.13.4.11304
(ck=6ed)
5/24/20 | v2.4.2 |
---|
LVL 60 Dwarf Holypriest
Naked 119 Int = would be 2,01 Spellcrit (119/59,2) but ECS showing 2,8% spellcrit.
Why? Where does this 0,8% Critchance come from?
BR Anticheater
Reported on Curseforge:
The Shaman talent "Nature's Grace" seems to be calculated double. It might be because either "GetHitModifier" and/or "GetSpellHitModifier" already counts in the values from the talent.
This could also effect Rogues.
v2.1.2
Why does the casting MP5 (200) on my shaman simply show up as MP5 from spirit (145) + MP5 from gear? (55)
Is this a problem with shaman? Shaman gets nothing from spirit unless using blue dragonscale.
Currently only block chance is displayed (The tooltip states block value which should be changed to block chance). Displaying block value would also be helpful.
This can be found with GetShieldBlock() .
First, thanks for this fresh addon !
I searched for a french version but i can't find it, probably it doesn't exist ? =p
So I made some modifications to translate it into french.
This is the link to my french version ! (from google drive) :)
Cheers !
PS: I added my nickname to the readme and the .toc file ^^''
The 3% increase to nature spell crit from T2 shaman five set bonus does not show up.
v2.4.4
Neither the ECS button nor "/ecs toggle" toggles the ECS window
v2.1.2
MP5 (casting) bonus for Stormrage 3-set bonus is not yet implemented.
Using Reflection talent + 3-set bonus should add up to 30% of MP5 (Spirit)
Love this addon!
Version: v2.1.4
Reported on Curseforge: The paladin talent which adds 5% holy crit might not be taken into account.
2.1.4
Spell hit shows no bonus with Warlock talent Suppression.
Is this because this talent is only for Affliction spells and not all spells?
For mage, the stat "MP5 (Casting)" does not take into account whether mage armor is currently active on the player.
2.4.4
Hello, this was marked as closed but the regen from the priest ZG enchant doesn't seem to be being counted and I'm not sure if my post in the closed thread will cause an alert, so please see screenshots and thanks for your mod!
Originally posted by @Windermericon in #28 (comment)
Pressing the escape key doesn't close the settings frame, but just the character frame.
v2.0.0
Not sure if I'm missing something, but it seems like there is no such function right now and when I want to see all my spell stuff on the warlock I end up having to see them on my Warrior too and vice versa with other stats the Warlock might not care about.
If there truly isn't a way to have different profiles for ECS yet, can we get it? Thanks!
Add the damage modifier for melee glancing blows.
After downloaded the addon, click enable in game, it still does not show in the character page.
Tried /ECS command too, but none happen after pressing enter
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.