GithubHelp home page GithubHelp logo

Comments (11)

brentvatne avatar brentvatne commented on July 17, 2024

Hi @soliury! Can you give me some example code where this happens? If you can do that I can surely fix it for you 😄

from react-native-overlay.

osdio avatar osdio commented on July 17, 2024

I have delete the wrong code.

But I can discribe in words:

I put a overlay in a sence named topic, I push the sence in a sence named tab, and then, turn to the topic sence, but when I pop this sence by use navigator.pop() it works, the overlay can disdrory, but when I use gesture to pop it , it can't disdrory, it will show in tab sence.

from react-native-overlay.

brentvatne avatar brentvatne commented on July 17, 2024

@soliury - thanks! I'll try to reproduce

from react-native-overlay.

albertwchang avatar albertwchang commented on July 17, 2024

@soliury I wonder if you set the boolean variable that would be used by the Overlay's isVisible property to false. Set this boolean variable in the `Topiccomponent'scomponentWillUnmount()`` method...

from react-native-overlay.

travisyeh avatar travisyeh commented on July 17, 2024

I'm experiencing a similar issue. I have the following in my Overlay:

componentWillUnmont(){

    this.props.isVisible = false;
    this.render();
},

However, there is always about a second of lag before the Overlay actually removes itself, and it sometimes fails to do so for a few seconds. Furthermore, when I cmd+R to refresh the JS and load a new preview of my app, the Overlay stays on the simulator and doesn't remove itself. Is there another way I can reliably remove the Overlay?

Thanks so much!

from react-native-overlay.

brentvatne avatar brentvatne commented on July 17, 2024

If anyone has a chance to investigate this further it would be much appreciated! Unfortunately I have higher priority tasks to work and this library currently solves all of the needs that I personally have for it :)

from react-native-overlay.

louuysison avatar louuysison commented on July 17, 2024

Can confirm this issue. Setting isVisible={true} then replacing the route in navigator via an async function. Overlay does not disappear and isVisible. Even refreshing the JS via react native menu does not remove the overlay. Need to close the app via app manager or Xcode. Might have something to do with how the component deals with being unmounted?

from react-native-overlay.

niftylettuce avatar niftylettuce commented on July 17, 2024

Might you need to change this:

constructor(props) {
  super();
  // ... this.state or whatever
}

to this?

constructor(props) {
  super(props);
  // ... set state or whatever
}

@louuysison @Achang28 @travisyeh did you fix?

from react-native-overlay.

niftylettuce avatar niftylettuce commented on July 17, 2024

See #36 - we will be refactoring this soon to support Android/iOS and not have any issues here, there will no longer be the XCode integration needed

from react-native-overlay.

dvcrn avatar dvcrn commented on July 17, 2024

Similar problem here. I try to dynamically change components inside the overlay but while the component is getting destroyed, it is still drawn onto the screen. Any workaround?

from react-native-overlay.

HeyItsJs avatar HeyItsJs commented on July 17, 2024

Hey guys, I am facing the same issue. Its more than 6 years since this issue is opened. Is there any workaround?

from react-native-overlay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.