Comments (4)
@jlkalberer I think in the long run this would be a good change. Some load balancing strategies in particular would greatly benefit from not using local storage for attributes and keys.
Cheers!
from spark-server.
Thanks.. I just wasn't sure if it would be OK with the change because it will really add some opinionated code. I think the benefits will really help out with maintaining this codebase though.
from spark-server.
I think having some opinionated code is not so bad, it can encourage developers to follow your design. I have never worked with DI and IOC in JavaScript but I have experiences with Symfony that makes a large use of DIC so i guess it could bring only benefits.
from spark-server.
Ok, this wasn't as bad as I thought. Instead of using the @Dependencies
syntax, I added some files that set up the bindings. Everything seems to be working as the change wasn't too large.
@AntonPuko - I think your tests should be verifying that all the APIs work but I'm guessing there are some new APIs that don't have tests yet.
from spark-server.
Related Issues (20)
- .env not working if spark-server is used as dependency HOT 5
- Error on spark-server update-firmware HOT 4
- Response timeout for event: spark-server/call_device_function HOT 5
- ERROR: DeviceServer.js for local server HOT 2
- firmware device counter increases with failed flash attempts HOT 2
- Cannot upload device IDs with non-numeric characters
- Hook for device status change? HOT 3
- Is there a way to pass the contents of the publish event directly to MQ? HOT 7
- Memory Leak
- update-firmware requests failing HOT 3
- support for mesh devices HOT 1
- Function call returns error when firmware function returns zero HOT 6
- Electron session end after every 30 seconds HOT 5
- Throws error on starting spark-server HOT 1
- device names not accepted as deviceId - breaks particle-cli HOT 15
- Device.js/14528 on hostName: Device disconnected (cache_key=_5, deviceID=deviceid, duration=46.791, disconnectCounter=1) HOT 1
- Error with handshake process HOT 32
- Claiming / provisioning a devices without an deviceID HOT 5
- Does this still work? HOT 15
- Is there a renamed implementation of Particle.subscribe(particle/device/name); ? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spark-server.