about events about spark-server

[jlkalberer]

Yeah, I think we will make them work like the normal cloud.

Right now I'm filtering out all private events...
https://github.com/Brewskey/spark-protocol/blob/dev/src/server/DeviceServer.js#L353-L356

I wasn't sure which events should be visible when you call those APIs. I know some should be hidden though. You have any idea?

[jlkalberer]

@AntonPuko - do you want to take care of this one?
I see a TODO here that deals with it I think:
https://github.com/Brewskey/spark-protocol/blob/dev/src/server/DeviceServer.js#L122-L128

[durielz]

Well, all the events that start with 'spark' should be hidden except for the special events https://docs.particle.io/reference/api/#special-events

Custom public and private events should be shown following the rules above

[jlkalberer]

Awesome. I have a large diff going out that is removing todos and I just disable the filter for now..

I'll work on this next and add the filter back in.

[jlkalberer]

Also, @durielz I can send you an invite to our slack channel if you want. It might help with some of this communication.

[durielz]

Ok! Il giorno sab 14 gen 2017 alle 21:38 John Kalberer <[email protected]> ha scritto:

…

Also, @durielz <https://github.com/durielz> I can send you an invite to our slack channel if you want. It might help with some of this communication. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFwN493N6XCASEL19IhkXHb8heqpB8Quks5rSTJBgaJpZM4LjnvF> .