Comments (2)
Is making a change "on the radar"? Considering you're the first to ask for it, probably not yet, though third-party PRs are always welcome of course. But:
- Do you need the eager loading in the places where you would like to use
union
? - Can you move the eager loading after the union?
In the other thread you mentioned your scopes have eager loading. Without seeing your application, my intuition is that placing includes
etc. in a scope is premature. In any case you should be able to write:
relation_1.union(relation_2).includes(...)
I haven't done Rails work in a while so I don't remember specifically, but I think the above should work.
from active_record_union.
@brianhempel Thank you for the quick response!
I'm following your suggestion in places where I can, where simple relations are being used. However, unfortunately, in my code, a lot of the associations come via multiple different models (scopes were just one example), and hence moving includes
away means changing a lot of code at a lot of places.
I understand that it might not be worth the effort based on a single use-case, but hope it starts the discussion.
from active_record_union.
Related Issues (20)
- Cannot union relation with includes HOT 6
- Support for sinatra-activerecord HOT 1
- There are different results of UNION subqueries depending on mysql version HOT 1
- nil.union(something_not_nil) HOT 1
- Feature request: union relations and SQL strings HOT 1
- Associated scopes – Major security issue HOT 3
- Interested in supporting intersect and except? HOT 4
- Problem with (empty result).update_all
- union doesn't work for union of fields
- Union of multiple columns on 2 tables with no relationship
- Feature request: Test on Rails 6.0
- PG::SyntaxError: ERROR: syntax error at or near "desc"
- How can I get the UNION of 2 different tables HOT 1
- `union` ignored if used in a merge
- gem does not work with SQLServer
- Not binding polymorphic relation HOT 3
- Is flat union chaining possible? Is it preferable to nested? HOT 3
- Fails on Rails 4.1 + PostgreSQL: bind supplies 2 parameters, but prepared statement requires 1 HOT 6
- Fails on Rails 5.0.0.beta3: undefined method `visitor' for ActiveRecord::Relation HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from active_record_union.