Carbon object in methods parameters ?! about carbon

[Anahkiasen]

Carbon objects are DateTime objects.

[kylekatarnls]

But a "Carbon" in parameter type do not allow DateTime (non-Carbon) to be passed.
patie, you can extends this method safely with :

public function diffInDays(DateTime $dt = null, $abs = true)
   {
      $dt = ($dt === null) ? static::now($this->tz) : new Carbon($dt);
      return intval($this->diff($dt, $abs)->format('%r%a'));
   }

With doing new Carbon($dt), you're sure $dt will be a Carbon object even if a pure DateTime is passed.

[patie]

@Anahkiasen :)

im talking about this..

$today = new \DateTime();
$tommorow = new Carbon;
echo $tommorow->diffInDays($today);

Catchable Fatal Error: Argument 1 passed to Carbon\Carbon::diffInDays() must be an instance of Carbon\Carbon, instance of DateTime given

if i have DateTime object from ORM for example.. i must transfer this DateTime into Carbon first to use.. but understand

[kylekatarnls]

The ->diff method is not overrided by Carbon so It could be changed by \DateTime with no consequence.

[patie]

thx, but imho all can be working with DateTime always, now its not possible because BC, but maybe will be better always receive DateTime object (or better interface), and if its needed into method convert into Carbon, process Carbon and again return DateTime - so i know i always inject and get DateTime.

DateTime (controller) -> Carbon (carbon lib) -> DateTime (controller)

and i dont must convert this in controller, service whatever (clean and slim), because library do this for me. its ONLY IDEA, maybe not possible (i dont look at full source), and as i say BC is not welcome for sure.

[briannesbitt]

Don't think simply changing the parameter type will work. If you actually pass in a DateTime it will try to call methods on the object that don't exist.

[briannesbitt]

Going to close this for now. Most of the popular frameworks now use Carbon natively.