setTestNow() and createFromDate() about carbon

[briannesbitt]

Ah yes. The "relative keyword" match is matching the minus signs incorrectly.

[briannesbitt]

Fixed with a test. 21c4cb4

[pesterhazy]

Thanks, the issue is fixed for me in 1.8.0!

Relatedly, is this the expected behavior?

[1] boris> Carbon\Carbon::setTestNow(Carbon\Carbon::createFromDate(2013,10,1));
 → NULL
[2] boris> echo new Carbon\Carbon . "\n";
2013-10-01 09:30:06

It correctly mocks the year/month/day, but takes the hour/minute/second from the current clock. That seems strange to me. If I do

Carbon\Carbon::setTestNow(new Carbon\Carbon("2013-10-1"));

instead, it does set the hour/minute/second to zero, as I expected.

[pesterhazy]

Note too that this, rather than using setTestNow(new Carbon(...)), seems to be the preferred way of mocking the current datetime, given that

Carbon::setTestNow(Carbon::createFromDate(...))

is in readme.me.

[briannesbitt]

Yes this is expected and documented. https://github.com/briannesbitt/Carbon#api-instantiation

createFromDate() will default the time to now. createFromTime() will default the date to today. The ctor passes through to the DateTime ctor and relies on its implementation.

You can always use create(2012,1,1,0,0,0) to set the time to zeros... or startOfDay().

setTestNow() takes a Carbon instance so you can use any methods available to create your test instance.

[pesterhazy]

I see, that makes sense. Thanks for clearing things up.