GithubHelp home page GithubHelp logo

Comments (3)

tkaufmann avatar tkaufmann commented on June 11, 2024

Could it be that easy?

In 1.7, change line 815

return strftime($format, $this->timestamp);

to

return strftime($format, $this->timestamp + $this->getOffset());

from carbon.

briannesbitt avatar briannesbitt commented on June 11, 2024

It seems ok here.... although possibly not your desired value.

Your Carbon instance is holding a particular date/time with a timezone. strftime() takes timestamp (UTC) and formats it to your current locale settings. Part of your locale settings is your current timezone. So the method moves the timestamp to the current runtime env timezone and proceeds with the formatting.

Adding the offset doesn't work here. I think it has to set the default timezone and the reset it after the call.

I tried date_default_timezone_set() and ini_set('date.timezone', $carbon) and neither has worked here.
When I print out the %z is always says my current timezone rather than the timezone I just set.
If that would work then we can change up the implementation.

from carbon.

tkaufmann avatar tkaufmann commented on June 11, 2024

Darn! My php.ini set the timezone to Europe/Berlin, but the Laravel app.php set it back to UTC. After setting that to CET as well, strange behaviour is gone. Glad I didn't call it a bug ;-) Thanks for putting me on the right track.

from carbon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.