Developer Build Compile Time Errors, Test Status about brightstardb

[dgerding]

Update... I got rid of those errors by removing the reference to netcoreapp1.0 in the BrightstarDB.Tests project.

[dgerding]

I'm getting 131 failed to 278 passed... which is why I'm concerned about using this latest build.

I know you didn't use that last pull request... but is there some other way I can help?

[dgerding]

@kal Update: I've taken another pass at converting the existing to BrightstarDB project to .net standard 2.0, this time removing all the conditional compilation bits and related cruft code (200 little dorky edits). I then made a new .net core 2.2 nunit test project and now there are only 25 tests failing.

I'll probably do another pull request but we can chat first. I'm hoping you're willing to lose the .net 4.5 compatibilities since moving to .net standard 2 still supports .net 461.

[kal]

Hi Dave,

There was a compile time error introduced by a minor version update to Moq in which they took out support for netstandard 1.0. It seems a bit strange to me that they would do that on a minor update but anyway the fix is to change the package reference to be fixed to 4.10.1 which was the last version that supported netstandard 1.0.

Once I do that I can compile everything in the core solution (src/core/core.sln) and run the tests across all platforms and I get:

netcoreapp 1.0 - 1221 / 1221 tests pass
netcoreapp 2.0&2.1 - 1305/1305 tests pass
.net451 - 1290/1290 tests pass

The netstandard 2 support is split across netcoreapp 2.0 and 2.1 because the code generation tests require netcoreapp2.1 (as you've noticed I think from those error messages you are seeing).

I'm going to look at modifying the projects and the appveyor build so that commits to the develop branch package up and release nuget pre-release packages, but for now if you have access to VS (I'm using 2017 still at the moment) then please try just building and running the tests in core.sln from inside VS, or take a look at the appveyor.yml and follow the same steps as are used in there to build the solution.

[dgerding]

Hi Kal,
Hmm.. maybe it's because I'm on VS2019. I'll try the newest commit with the #319 fix and let you know.

If you decide you want the version of the BrightstartDB project with the target specific compiler directives (and non-standard 2 code snippets) removed let me know. I left a comment breadcrumb where I removed anything edit but it was basically manual search and replace. Single target .net standard 2.0 project.

Thanks for the quick reply.

[dgerding]

Thanks! (see note in #319)