GithubHelp home page GithubHelp logo

Comments (6)

mamazu avatar mamazu commented on September 26, 2024

Thanks for the offer, we will be working on it.

from syliustierpriceplugin.

mamazu avatar mamazu commented on September 26, 2024

I have refactored the code. However, I was wondering what repository was meant in the section stating

Repository name should use dashes as separator, must have a sylius prefix and a plugin suffix

in the Sylius documentation. Does it refer to the github repository or the composer package?

from syliustierpriceplugin.

Zales0123 avatar Zales0123 commented on September 26, 2024

It's definitely about composer package (for example friendsofsylius/sylius-import-export-plugin for SyliusImportExportPlugin etc.). Btw, you can take a look at SyliusShopApiPlugin - even though it does not keep all the conventions (it had been done long time before we established them), it's one of the best example how SyliusPlugin should look and work :)

from syliustierpriceplugin.

mamazu avatar mamazu commented on September 26, 2024

Ok, thanks. I moved the package and will prepare a release soon. Anything I forgot?

from syliustierpriceplugin.

Zales0123 avatar Zales0123 commented on September 26, 2024

Sorry for the reeeeealy long response time πŸ˜„It's fine now, the only thing that could be done yet is setting up Continuous Integration platform. We recommend https://travis-ci.org/, especially, because it's free for open-source project :) You can take a look at Sylius-Standard, to know what you're able to configure there. The same for https://github.com/Brille24/SyliusCustomOptionsPlugin.

This plugin is already on our Plugin page, the CustomOptionsPlugin will be listed there for sure in the nearest future :)

Thank you! πŸŽ‰

from syliustierpriceplugin.

mamazu avatar mamazu commented on September 26, 2024

Sounds great. I have already created a ticket for this issue. #5

from syliustierpriceplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.