Product menu listener crashes the product edit page about syliustierpriceplugin

[mamazu]

I will look into it. Thanks for reporting it.

[mamazu]

Okay, I have found the problem. The problem is that if it is a simple product we want the AdminProductFormMenuListener to be included. If it is a configurable product the product doesn't show the tierprices in the form but rather in the variants. There is a quick fix for it to just hide the content of the tab but this is not the best way to deal with it, I would say.

On the other hand I don't think that there is a way to destinguish in the MenuListener when is it a simple product and when is it a configurable product.

[mamazu]

Never mind I have fixed it I think. Have a look at: e3c45ca.

[wimulkeman]

That does seem to be a good fix. Thanks

[mamazu]

You're welcome

[sabehira]

Could you please clarify how to do to fix this bug? Thanks.

[mamazu]

You can cherry-pick this commit e3c45ca or manually implement the changes.

What I have done so far is that I have added a condition to the MenuListener that adds the tierpricing. When it is a configurable product, it will not add the Menu entry to the product menu and just the product variant entity.

[wimulkeman]

@sabehira What I did in my project was disabling the service which registers the listener. That could work in the meantime if you're working with a build process and can't implement the changes in the vendor.

To remove it, you need to add a compiler pass with the following code:

<?php

namespace AppBundle\DependencyInjection\Compiler;


use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class ThirdPartyServiceRemovalPass implements CompilerPassInterface
{
    public function process(ContainerBuilder $container)
    {
        $container->removeDefinition('brille24.listener.admin.product.form.menu_builder');
    }
}